Scale and offset fields in ModuleBasisFunction are assigned, yet never used.

[codetaylor]

Scale and offset fields in ModuleBasisFunction are assigned, yet never used.

[codetaylor]

After looking at the code this was derived from, the implicitbasisfunction.cpp in ANL, I have concluded that these values are probably unnecessary.

A comment about the setMagicNumbers() method by the original author:

This function is a damned hack.
The underlying noise functions don't return values in the range [-1,1] cleanly, and the ranges vary depending on basis type and dimensionality. There's probably a better way to correct the ranges, but for now I'm just setting he magic numbers m_scale and m_offset manually to empirically determined magic numbers.

It may be that the magic numbers were abandoned in favor of the auto-correction module.

I will be removing these fields and the associated method.