change tempo

[sugarlabs]

change tempo

[walterbender]

I added a constant in logo.js to tweak the timing of notes. To my ear and by measurement using the Time block, setting BPMFACTOR = 2 gives us 120 quarter notes per minute. @pikurasa maybe you could test other values and determine a good default?

@khandelwalYash I cannot seem to get Tonejs to set bpm nor does it seem that the default of 120 is what we are hearing.

[pikurasa]

Okay, I will think about it.

Off the top of my head, 120 seemed a little brisk and 60 was too slow. Maybe in the 90-100 area...

I am going for a "mindful and singable" speed.

Devin

[walterbender]

I made the code a bit more explicit and exposed BPM in the UI (under the Tone palette). I want to make this work properly in the Tone.js framework, but to my ear the current work-around is working. (Also set the default to 90.)

[khandelwalYash]

BPM can be changed by using .bpm member of Tone.Transport.
Its default value is 120, it is mentioned the link -> http://tonejs.org/docs/#Transport

[walterbender]

Yes. But I think the problem is we are sending a time interval when we play
notes, not a note specification. So I don't think it is doing anything.

On Sun, Oct 11, 2015 at 9:03 AM, Yash Khandelwal [email protected]
wrote:

BPM can be changed by using .bpm member of Tone.Transport.
Its default value is 120, it is mentioned the link ->
http://tonejs.org/docs/#Transport

—
Reply to this email directly or view it on GitHub
https://github.com/walterbender/musicblocks/issues/18#issuecomment-147191346
.

Walter Bender
Sugar Labs
http://www.sugarlabs.org

[pikurasa]

I think that you got this working pretty well so far. Tested a few BPM against my metronome (60,90,120,240) and they checked out.

One note: I am able to input zero as an argument for BPM. I think we need (explicit) lower level. The lower limit on my metronome, for example, is 36 (It is all kind of arbitrary, but "0" doesn't make any sense at all).

[walterbender]

I think I do check for < 30 and > 1000 but I don't report it to the user.
Please check again with the latest patch: it will change 0 to 30 but also
issue a warning.

On Tue, Oct 13, 2015 at 2:23 PM, Devin Ulibarri [email protected]
wrote:

I think that you got this working pretty well so far. Tested a few BPM
against my metronome (60,90,120,240) and they checked out.

One note: I am able to input zero as an argument for BPM. I think we need
(explicit) lower level. The lower limit on my metronome, for example, is 36
(It is all kind of arbitrary, but "0" doesn't make any sense at all).

[image: screenshot - 10132015 - 02-19-32 pm why can i even input a zero as
tempo argument]
https://cloud.githubusercontent.com/assets/13454579/10464093/01018654-71b6-11e5-8d82-50a2fae46d7c.png

—
Reply to this email directly or view it on GitHub
https://github.com/walterbender/musicblocks/issues/18#issuecomment-147803140
.

Walter Bender
Sugar Labs
http://www.sugarlabs.org

[pikurasa]

Seems to work.

[walterbender]

there are some design questions that will be raised in a new issue.