Investigate reason why there are duplicate pitches in Phrase Maker

[pikurasa]

Investigate reason why there are duplicate pitches in Phrase Maker

[pikurasa]

music.webm In the provided video, when selecting the "phrase maker," a noticeable issue becomes apparent. Initially, a large dialog box appears, followed by a smaller one. However, the expected behavior is for only the smaller dialog box to be displayed directly. This discrepancy in the appearance of dialog boxes is the identified issue. @walterbender

No.

The dialog box appearing larger, then smaller is not what this issue is about. I suppose it would be nice if it skipped displaying that step, but what is going on in the two steps is this: The larger dialogue box is all of the pitches that are output, the second step is to find duplicates and display only the unique pitches.

This issue is not about that. This issue is about pitches that are otherwise equivalent that are displaying, even after finding duplicates. In your video, at around 9 seconds, it has both Fa#5 and F#5. Those two pitches are the same. The former is using solfege, and the latter is musical alphabet, but otherwise they represent the same pitch. We should only have one of them.

These are the pitches that are the same:

Is this helpful info?

[brf153]

@pikurasa sir, in the phrase maker, I think either we should have notes in the alphabet or in solfege. Should I remove ti as B is already there(in the C major scale)? Also, should I replace do5 with C5?

[khadar1020]

can I solve this issue as it is labelled GSOC I am asking your permission @pikurasa @walterbender

[walterbender]

no need to ask for permission.

[khadar1020]

music.webm
In the provided video, when selecting the "phrase maker," a noticeable issue becomes apparent. Initially, a large dialog box appears, followed by a smaller one. However, the expected behavior is for only the smaller dialog box to be displayed directly. This discrepancy in the appearance of dialog boxes is the identified issue. @walterbender

[khadar1020]

got it, @pikurasa sir, F#5 and fa#5 only one has to be there one small doubt only one such pitch is duplicated(F#5 and fa#5) right and remaining all pitches are only once written

[khadar1020]

there are two ways to do this @pikurasa

1. adding a simple if-else condition so that we can remove fa#5 from the phrase maker
2. we can also remove from the rowLables array itself only fa#5 element
   I think 1st choice is the best because we may use rowLabels array in different cases
   here is the screen shot after removing duplicates
   

[walterbender]

There is code that sorts the pitches by frequency. Duplicates should be identifiable after that step.

[khadar1020]

if(obj[1]!=='fa♯')
this.rowLabels.push(obj[1]);
this.rowArgs.push(Number(obj[2]));

by this code in phrase maker it will remove fa#5 can I do it or remove the fa#5 from the obj itself @pikurasa

[khadar1020]

can you say any conditions to how to find out the duplicate pitches @walterbender

[walterbender]

There should already be some code that converts the note to HZ. Then we sort and can remove dups.

[ChiragJS]

is anyone working on this issue?
Are you working on it @khadar1020 ?

[walterbender]

Feel free to jump in. (There is a PR but it is not correct.)

[ChiragJS]

please review it

[khadar1020]

due to my sem-end exams, I was not able to contribute to it for some time you can contribute to it with no issues as @walterbender said @ChiragJS

Thank you

[ChiragJS]

no worries and thank you !