Comments (3)
@tynor Thanks for the issue!
I will take a look.
from aigle.
@tynor I checked the global.Promise
type definition.
PromiseConstructor
doesn't allow PromiseLike
and restricts that all methods need to return Promise
instancies.
Aigle
implements PromiseLike
and returns Aigle
instancies. So you can't assign Aigle
to global.Promise
without as any. (You could override the global Promise
type definition if you really need.)
import Aigle from 'aigle';
global.Promise = Aigle as any;
const foo: Promise<number> = Aigle.resolve(10); // doesn't work, because Aigle doesn't extend Promise
const foo: Aigle<number> = Aigle.resolve(10); // works
const foo: PromiseLike<number> = Aigle.resolve(10); // works
Adding the Symbol.species
handling doesn't help the issue, but I added it on #141, thanks!
from aigle.
@suguru03 Thanks for taking a look! I'll go bug libraries I use to use PromiseLike
. :)
from aigle.
Related Issues (20)
- Adding allSettled function as in Q library HOT 4
- An in-range update of uglify-js is breaking the build 🚨 HOT 1
- An in-range update of uglify-js is breaking the build 🚨 HOT 1
- es5 files are empty HOT 1
- not better than async in http request HOT 3
- Add progress method for promises HOT 1
- An in-range update of uglify-js is breaking the build 🚨 HOT 22
- add tapCatch method HOT 1
- .retry: add predicate option, which could be used to decide which errors should trigger a retry HOT 2
- Migrate tslint to eslint
- An in-range update of semver is breaking the build 🚨 HOT 2
- An in-range update of lint-staged is breaking the build 🚨 HOT 12
- An in-range update of prettier is breaking the build 🚨 HOT 1
- An in-range update of mocha is breaking the build 🚨 HOT 2
- An in-range update of codecov is breaking the build 🚨 HOT 1
- An in-range update of nyc is breaking the build 🚨 HOT 1
- Bug: Aigle tries to call `then` even if it's not a function HOT 1
- Aigle.each et al: if first argument is a Promise, resolve it before iterating over it HOT 1
- mixin lodash use concat "Confuse" HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aigle.