Giter Site home page Giter Site logo

Comments (3)

suguru03 avatar suguru03 commented on June 17, 2024

@tynor Thanks for the issue!
I will take a look. 🙂

from aigle.

suguru03 avatar suguru03 commented on June 17, 2024

@tynor I checked the global.Promise type definition.
PromiseConstructor doesn't allow PromiseLike and restricts that all methods need to return Promise instancies.

Aigle implements PromiseLike and returns Aigle instancies. So you can't assign Aigle to global.Promise without as any. (You could override the global Promise type definition if you really need.)

import Aigle from 'aigle';
global.Promise = Aigle as any;
const foo: Promise<number> = Aigle.resolve(10); // doesn't work, because Aigle doesn't extend Promise
const foo: Aigle<number> = Aigle.resolve(10); // works
const foo: PromiseLike<number> = Aigle.resolve(10); // works

Adding the Symbol.species handling doesn't help the issue, but I added it on #141, thanks! 😄

from aigle.

tynor avatar tynor commented on June 17, 2024

@suguru03 Thanks for taking a look! I'll go bug libraries I use to use PromiseLike. :)

from aigle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.