Lag tapping on days?

[sundeepk]

Lag tapping on days?

[spartacusrex99]

There is a much easier fix..

Switch OnSingleTapConfirmed for onSingleTapUp..

OnSingleTapConfirmed waits to make sure you are not double clicking.

[SundeepK]

I'll have to run the example that's shipped with the code to test things out when I get the time, but what version are you running? Are you on the latest?

[broakenmedia]

Yep, latest!

[SundeepK]

Ok thanks. There is a slight bit of lag clicking days, it's something that I wanted to looks at for a while. There's some calculations that are running to find the correct day that was click. The only things I can do is run some android code profiling commands to figure out where most of the cpu time is spent. I have a suspicion though that the calendar is being redrawn an extra time than needed. So instead of drawing once, it draws twice.

[SundeepK]

So after a little investigation and profiling, the code doesn't look like it's actually slow or drawing unnecessarily. However, I am using GestureDetector.SimpleOnGestureListener to listen for onSingleTapConfirmed event. Looking through android source code, basically, GestureDetectorCompat android will wait for some time until an event is considered a single tap event. This time is what you see as the lag (at least I think so).

As an experiment, you can move the code from onSingleTapConfirmed method to on down in the CompactCalendar class. You will see that the UI updates immediately. However, this causes other issues with scrolling and oddities with gesture detection.

        @Override
        public boolean onSingleTapConfirmed(MotionEvent e) {
           // Date onDateClicked = compactCalendarController.onSingleTapConfirmed(e);
           // invalidate();
           // if(listener != null){
           // listener.onDayClick(onDateClicked);
           // }
            return super.onSingleTapConfirmed(e);
        }

        @Override
        public boolean onDown(MotionEvent e) {
            Date onDateClicked = compactCalendarController.onSingleTapConfirmed(e);
            invalidate();
            if(listener != null){
                listener.onDayClick(onDateClicked);
            }
            return compactCalendarController.onDown(e);
        }

So the fix? Well I can see implementing custom gesture detection as one way of doing things without much thought. But I'll have to think about this a little bit :)

[SundeepK]

Thanks for the comment, I'll investigate this soon then.

[yoavst]

@spartacusrex99 fix is great, but why isn't it integrated? your comment is from april.

[SundeepK]

@yoavst Mostly because I have been implementing other feature and enhacements. There is some pull request I want to merge before. Once that feature is merged I will have a look at this.

[yoavst]

Thanks! Currently I'm not using this library, but I'll be happy to use this library for performance reason.

[SundeepK]

So good news, this has been fixed and will be merged some time this week. Will update once a new version is out.

[SundeepK]

Merged will release a new version some time in the next few days.