Incompatibility with minified versions of videojs

[sunnyli]

Incompatibility with minified versions of videojs

[SunnyLi]

Any specific error you are getting?
Anyways I'll look into it now.

edit:
I've updated this plugin to be compatible with libjass v0.9.0 which might have caused some problems.
I've also tested the updated version on bower/npm with the latest videojs v4.11.3 which works.
hope it resolves your problem.

[Denoder]

is it only suppose to be specifically working with youtube videos? Ive tried replicating the same build as you have y building libjass but when i use it i get some error relating to libjass + renderer-null unexpected length. (Am i to use the dev version of videojs or the normal version)

Ill try replicating the problem again and giving screenshots

[SunnyLi]

is it only suppose to be specifically working with youtube videos?

No, you can probably use any provider.
I used the YouTube provider because the video I need is there.

Am i to use the dev version of videojs or the normal version

Yeah, you'll have to use the dev version.. until videojs/video.js#1586 gets resolved. 😇

Ive tried replicating the same build as you have y building libjass but when i use it i get some error relating to libjass + renderer-null unexpected length.

are you on the latest version which I've just pushed less than an hour ago?
how did you get the source? bower/npm/git (if you were using git, which branch were you on?)

[Denoder]

i think the the 2nd issue you mentioned might be the problem. And ill build the newest one now and test it.

[Denoder]

Alright that seems to have worked. I just wish i didnt have to use the dev version because i want to minify it.

[SunnyLi]

Glad to hear that you got it working. 😃

Actually, you can in fact use the minified version videojs with the current version of this plugin
(I've tested it just now) although the show/hide subtitle toggle button will no longer work.

You can disable the subtitle toggle button by setting the option like this:

plugins: {
  ass: {
    'src': "some_subtitle.ass",
    'button': false
  }
}

You can implement your own function to show/hide the subtitle if you need so.

[Denoder]

Meh ill just live with the dev version for now. Would you like to see how
i've implemented it?
Because im wondering if it would be possible to have the button for
multilangual purposes.

On Thu, Jan 22, 2015 at 8:05 PM, Sunny Li [email protected] wrote:

Glad to hear that you got it working. [image: 😃]

Actually, you can in fact use the minified version videojs with the
current version of this plugin
(I've tested it just now) although the show/hide subtitle button will no
longer work.

You can disable the show/hide subtitle button by setting the option:

plugins: {
ass: {
'src': "some_subtitle.ass",
'button': false
}
}

—
Reply to this email directly or view it on GitHub
#2 (comment).

[SunnyLi]

I think you'll need to modify this plugin quite a bit if you need it to load multiple subtitle files
but it is definitely possible.

I'm not planning to add more features to this plugin at the moment,
but if you got something great working feel free to submit a pull request.

[Denoder]

Well the only thing i've managed to do was make it work with a responsive
videojs player that has a 16:9 aspect ration whenever the browser resizes
or when ur on a phone. It's just some small css edit in lijass.css though
and removing the "px" in the video.ass.js

On Fri, Jan 23, 2015 at 1:18 AM, Sunny Li [email protected] wrote:

I think you'll need to modify this plugin quite a bit if you need it to
load multiple subtitle files
but it is definitely possible.

I'm not planning to add more features to this plugin at the moment,
but if you got something great working feel free to submit a pull request.

—
Reply to this email directly or view it on GitHub
#2 (comment).

[Sita-]

Teranode, are you able to supply those fixes? It may help me with my problem on mobile and responsive player.

[SunnyLi]

Hi, I've released v0.5 of this plugin which supports minified version of videojs 5.x.

Just so you know. 😄

PSA: v0.5 has now been into master! so I'm closing this ticket. 😃