memory leak when used with observer

[sunspot]

memory leak when used with observer

[alindeman]

Does the observer have any code in it?

[jeanmartin]

nope, I followed exactly the mentioned steps...

[danoph]

I'm having the same issue...each request is adding 5-10 mb and i have to restart my development server every few minutes

[alindeman]

Gross. I'll look into this later today if nobody else gets to it first.

[danoph]

It seems like the observer isn't the only thing causing a memory leak...Ever since I upgraded to sunspot rc3 (using solr 3.3) my app has been leaking memory like crazy

[alindeman]

Looking now. Thanks for the excellent bug report.

[alindeman]

Are you seeing this in production or only in development? I am only seeing it in development, so my gut is that it is related to class reloading (cache_classes = false)

[danoph]

I am only seeing it in development. I was guessing it was class reloading and sunspot was keeping some objects/results around for some reason...I also thought it could be something with the solr logger added for debugging?

[alindeman]

Ugh, all my attempts at using memory profilers in Ruby is failing. I'll try again sometime tomorrow.

[alindeman]

Back on the case of this. Might try JRuby, heh.

[alindeman]

Most likely suspect is 03fc76b#commitcomment-680536. I'll verify tomorrow though.

[alindeman]

@nz, will you review alindeman@2b5e8a7 ?

@jeanmartin, @danoph, will you try this branch to see if it fixes the memory leak for you too?

In Gemfile:

gem 'sunspot', :git => 'git://github.com/alindeman/sunspot.git', :branch => '108_memory_leak'

Then:

bundle update sunspot

[nz]

@alindeman looks good and makes sense. thanks for cleaning up after me ;)

[alindeman]

No problem!! This is not something that I really knew about until very recently too.

[alindeman]

Cool, thanks for reviewing! I've merged it in.