Comments (7)
cc @cedricziel
I'm not quite sure of the smoothest way forward here.
I'm suggesting we:
- Revert https://github.com/Superbalist/flysystem-google-storage/pull/6/files
- Create a new release fixing existing implementations.
- Create a new RC release allowing only RC2 to 2.0.0 and changing our code to support to the new credentials handling as per https://github.com/google/google-api-php-client/blob/master/UPGRADING.md#google_auth_assertioncredentials-has-been-removed
from flysystem-google-cloud-storage.
I'd say:
1.) Branch off 1.x, Remove the 2.0 constraint (or to cause less harm pin the last working RC) and release a new patch version as a fix for existing users
2.) on master, use a constraint on the final 2.0 client and tag a new major version
I'm pretty sure that's the way to go :)
from flysystem-google-cloud-storage.
So basically what you're saying, @matthewgoslett :D
from flysystem-google-cloud-storage.
I can't seem to find any RC version which still has the Google_Auth_AssertionCredentials class and old way of defining service credentials.
Can you confirm how you have it working your side, from when you requested the 2.0.0@RC be allowed?
from flysystem-google-cloud-storage.
Fixed in release 1.0.4 - https://github.com/Superbalist/flysystem-google-storage/releases/tag/1.0.4
I'm going to work on a new RC2 our side which uses the updated google/apiclient.
Apologies for the breakage here.
from flysystem-google-cloud-storage.
I've allowed for google/apiclient 2.0.0@RC in https://github.com/Superbalist/flysystem-google-storage/releases/tag/2.0.0-RC1
from flysystem-google-cloud-storage.
Thx Matthew - it's currently a bit out of scope, but I'll get back to testing and improving.
from flysystem-google-cloud-storage.
Related Issues (20)
- Renaming and moving Folders does not work HOT 1
- Function getOptionsFromConfig() is not working HOT 1
- undefined method: getUrl(); HOT 1
- get url from firebase storage using php
- has function does not return true for directories HOT 2
- upload fails with uniform access controls HOT 4
- ReadMe Correction for getUrl
- Supporting Flysystem 2.x HOT 4
- Getting 404 when i try to delete directory.
- File stream is dropped on writeStream() HOT 5
- Question: is it possible to set Cache-Control? HOT 1
- Authetification Issue HOT 2
- What's the status of this project? HOT 2
- Dependencies flysystem
- Could you update the library
- How to delete a dir with millions of files?
- PHP Warning thrown after asset Uploaded - stream provided gets corrupted HOT 1
- GoogleStorageAdapter::deleteDir fails to delete a directory HOT 2
- Is there a reason to explicitly set the visibility if not passed? HOT 7
- Changes to google api endpoint HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flysystem-google-cloud-storage.