Comments (8)
my mistake, need to use Chrome to login to Collide, firefox does not work well.
plz ignor this issue
Original comment by [email protected]
on 10 Jul 2012 at 4:41
from collide.
Original comment by dragonsinth
on 10 Jul 2012 at 4:57
- Changed title: Make login work for FirefoxFirefox
- Changed state: Accepted
- Added labels: Priority-High
- Removed labels: Priority-Medium
from collide.
I have a handle on why this happens.
Firefox adds "; Charset=UTF-8" to xhr requests mime-type and the code we have
in place just does "if
("application/x-www-form-urlencoded".equals(contentType))"
I'll save you the hassle of reading the bug
(https://bugzilla.mozilla.org/show_bug.cgi?id=416178) but they won't fix it.
Chrome doesn't do this so chrome works fine.
I think the proper thing here is to just strip anything after ; if ; exists,
then check this if block. So I'm going to do that. More ideally would be if
the java servlet framework didn't blow and this sort of stuff didn't have to be
done manually :)
writing a patch now
Original comment by [email protected]
on 19 Jul 2012 at 4:56
from collide.
Well I fixed hte login, and all it did was uncover how little testing we did in
firefox :)
I'm going to try to rejigger our excessive use of display:box in the header
since it causes firefox to have a stroke. Once I've done that I'll post a
patch here.
Original comment by [email protected]
on 19 Jul 2012 at 5:20
from collide.
Ta-da also should these bugs be cc'd to our mailing list?
Original comment by [email protected]
on 19 Jul 2012 at 5:45
Attachments:
from collide.
Quick note: I just did git format-patch --stdout master > firefox.patch so I'm
not sure if that was the right way to do that.
I think ideally I should have created a new branch and rebased squashing
everything into a single commit. I did read somewhere though that you can do
git am < firefox.patch and the multicommit patch file should work?
Original comment by [email protected]
on 19 Jul 2012 at 5:47
from collide.
Awesome. Thanks dude.
For future reference, you could also just push a git branch to the repo so we
can look at the commits with the web UI.
git push origin <local-feature-branch>:<shared-branch-name>
And when you are done with it, you can delete it by pushing "nothing" to it with
git push origin :<shared-branch-name>
Original comment by [email protected]
on 19 Jul 2012 at 6:50
from collide.
Did you mean to include those header changes? I had it on my todo list (and
already started the work) to just remove the header entirely, slide the content
area up, and make the Awesomebox a free floating UI component that hovers
above the editor.
Otherwise, Ship it :)!
Original comment by [email protected]
on 19 Jul 2012 at 6:53
from collide.
Related Issues (20)
- Underscores not displayed properly by the code editor HOT 9
- Bug in Cookies.java HOT 7
- Need top level ant target to produce a binary (was: Release tarball does not have containing directory) HOT 1
- lib/vertx/bin/vertx not compatible with 'dash' on debian. HOT 4
- Top level build should immediately create the directories Eclipse needs HOT 12
- Ant build failed if path contains "gen" HOT 10
- webroot directory config change doest not apply HOT 1
- Move directory on Windows throws AccessDeniedException HOT 1
- Ant build failed, reopen issue of 31 HOT 1
- Multibyte Support
- Can't login in IE HOT 1
- Can't login in Opera HOT 1
- List of collaborators doesn't update
- Choose port from command line HOT 1
- GrowableTextArea doesnt work for me HOT 1
- GWT DevMode in Firefox - JSNI Error HOT 1
- All files disappear when deleting single file HOT 2
- Code editor panel mouse offset problem.
- Upgrade to released version of Elemental
- There are no way to change listen address/port HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from collide.