Make login work for FirefoxFirefox

[GoogleCodeExporter]

Make login work for FirefoxFirefox

[GoogleCodeExporter]

my mistake, need to use Chrome to login to Collide, firefox does not work well. 
plz ignor this issue

Original comment by [email protected] on 10 Jul 2012 at 4:41

[GoogleCodeExporter]

Original comment by dragonsinth on 10 Jul 2012 at 4:57

• Changed title: Make login work for FirefoxFirefox
• Changed state: Accepted
• Added labels: Priority-High
• Removed labels: Priority-Medium

[GoogleCodeExporter]

I have a handle on why this happens.

Firefox adds "; Charset=UTF-8" to xhr requests mime-type and the code we have 
in place just does "if 
("application/x-www-form-urlencoded".equals(contentType))"  

I'll save you the hassle of reading the bug 
(https://bugzilla.mozilla.org/show_bug.cgi?id=416178) but they won't fix it.  
Chrome doesn't do this so chrome works fine.

I think the proper thing here is to just strip anything after ; if ; exists, 
then check this if block.  So I'm going to do that.  More ideally would be if 
the java servlet framework didn't blow and this sort of stuff didn't have to be 
done manually :)

writing a patch now

Original comment by [email protected] on 19 Jul 2012 at 4:56

[GoogleCodeExporter]

Well I fixed hte login, and all it did was uncover how little testing we did in 
firefox :)

I'm going to try to rejigger our excessive use of display:box in the header 
since it causes firefox to have a stroke.  Once I've done that I'll post a 
patch here.

Original comment by [email protected] on 19 Jul 2012 at 5:20

[GoogleCodeExporter]

Ta-da also should these bugs be cc'd to our mailing list?

Original comment by [email protected] on 19 Jul 2012 at 5:45

Attachments:

• firefox.patch

[GoogleCodeExporter]

Quick note: I just did git format-patch --stdout master > firefox.patch so I'm 
not sure if that was the right way to do that.

I think ideally I should have created a new branch and rebased squashing 
everything into a single commit.  I did read somewhere though that you can do 
git am < firefox.patch and the multicommit patch file should work?

Original comment by [email protected] on 19 Jul 2012 at 5:47

[GoogleCodeExporter]

Awesome. Thanks dude.

For future reference, you could also just push a git branch to the repo so we 
can look at the commits with the web UI.

git push origin <local-feature-branch>:<shared-branch-name>

And when you are done with it, you can delete it by pushing "nothing" to it with

git push origin :<shared-branch-name>

Original comment by [email protected] on 19 Jul 2012 at 6:50

[GoogleCodeExporter]

Did you mean to include those header changes? I had it on my todo list (and 
already started the work) to just remove the header entirely, slide the content 
area up,  and make the Awesomebox a free floating UI component that hovers 
above the editor.

Otherwise, Ship it :)!

Original comment by [email protected] on 19 Jul 2012 at 6:53