Giter Site home page Giter Site logo

Comments (4)

tsmethurst avatar tsmethurst commented on June 12, 2024

Ah, thanks!

from gotosocial.

Tsuribori avatar Tsuribori commented on June 12, 2024

Would using

	httpconv "go.opentelemetry.io/otel/semconv/v1.20.0/httpconv"
	semconv "go.opentelemetry.io/otel/semconv/v1.21.0"

mismatch be an acceptable quick fix? I guess it technically makes the whole thing schema non-compliant and is not a future-proof solution but it makes traces show up correctly. I haven't found anything to replace httpconv, though I'm not really an OTel expert

from gotosocial.

tsmethurst avatar tsmethurst commented on June 12, 2024

Mmm I'm not sure, possibly... I'll try to have a fiddle with this before we do our next minor release.

from gotosocial.

daenney avatar daenney commented on June 12, 2024

I'm a bit surprised this is causing an issue. There's many versions of the semantic conventions and it shouldn't be a stretch for v1.21 of the library to still request things be emitted with the v1.20 conventions.

I can spend a bit on fixing this, but that's going to have to wait a week or two. Instead of trying to randomly cobble together a version of the conventions that sort of just happens to work, I'd suggest just rolling back the dependency to 1.20. We just update them from now and then, but there's no real need to do so here in this case. That would solve the immediate issue, and then we can spend some time fixing it in a future-proof way after.

from gotosocial.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.