Giter Site home page Giter Site logo

Comments (5)

suren-atoyan avatar suren-atoyan commented on May 19, 2024

Screen Shot 2019-11-15 at 14 00 45

I see you had another change after updating the package version. Can I ask you to downgrade the package version, to be sure that the problem is definitely in the new version? And also please note which one is the latest "right" working version of the package.

Thank you!

from monaco-react.

suren-atoyan avatar suren-atoyan commented on May 19, 2024

Why I am asking this is because here is an example of ControlledEditor (which you are using) in version 2.3.0, and, as I saw, everything is okay so far.

from monaco-react.

luhis avatar luhis commented on May 19, 2024

you are right, rolling back React Monaco doesn't fix it. I can see what's happening now. It keeps emitting on change events, so it creates a feedback loop and runs away. I can see in the logs that the loops are alternating last char missing, last char present. I will probably just move to the uncontrolled input and that should solve the problem

from monaco-react.

suren-atoyan avatar suren-atoyan commented on May 19, 2024

Okay. And Please let me know if everything is okay, and we can close the issue.

from monaco-react.

luhis avatar luhis commented on May 19, 2024

so, i have left it as the controlled editor, but just removed the feedback of the state into the Editor component, so it is no longer crashing, but I don't think it is working correctly. I will have another look at it when i have some time

from monaco-react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.