Brilliant library, but I'm struggling with limited doco...

[davsun55]

Brilliant library, but I'm struggling with limited doco...

[davsun55]

A couple of tweaks but this is now working perfectly. Thanks for the hints.

        private void LoadVideo()
        {
            // Open the stream and immediately get a snapshot at the 3sec mark
            flPlayer.SeekCompleted += FLPlayer_SeekCompleted;
            flPlayer.OpenCompleted += (o, e) =>
            {
                if (!e.Success) return;
                flPlayer.SeekAccurate(3000);
            };
            flPlayer.OpenAsync(SampleVideo);
        }
        private void FLPlayer_SeekCompleted(object sender, int e)
        {
            flPlayer.SeekCompleted -= FLPlayer_SeekCompleted;
            if (e == -1) return;
            pbSnapshot.Image = flVideo.Player.TakeSnapshotToBitmap();
            flPlayer.Seek(0);
        }

[SuRGeoNix]

Hi @davsun55 and thanks!

I know that the documentation requires more work that's why I tried to include more samples/tests and also check XML documentation/comments.

1. Not sure what you want to do here (you can SeekAccurate to 2sec and then use TakeSnapshotToFile/TakeSnapshotToBitmap) or use PropertyChanged for CurTime and check when the current time is 2sec?

2. Stop should work like that (closing the input and clears the frame). What you need is to Pause and Seek(0).

3. Seek will seek at a keyframe (this means that it will not be accurate, depends from the video's GOP size) but it will be faster while SeekAccurate will be accurate but slower (as it needs to decode all the GOP frames until the actual timestamp). SeekBackward(2/3) and SeekForward(2/3) will use Seek or SeekAccurate based on Config.Player.SeekAccurate and the time offsets based on Config.Player.SeekOffset(2/3)

4. Don't use this, always use the Player Set/Seek time and then use this without a frame (to get the current one)

Feel free to ask for more details

John

[davsun55]

Hi John, I appreciate your response. I’ve taken your sample and tweaked a couple of things (mostly renaming controls) to test it all. I have this in the constructor: flConfig = new Config(); flPlayer = new Player(flConfig); And this in the form load: private void Form1_Load(object sender, EventArgs e) { flPlayer.OpenAsync(SampleVideo); flPlayer.Seek(2000, true); pbSnapshot.Image = flVideo.Player.TakeSnapshotToBitmap(); } The video starts playing correctly but there’s no snapshot. When I put in a breakpoint after the snapshot, I can see that the image is null. I’ve tried both ‘Open’ and ‘OpenAsync’, and ‘Seek’ and ‘SeekAccurate’. I’m using C# Winforms with .Net8 and FlyleafLib v3.7.42 from NuGet within the solution. I’ve zipped up my solution for info, less the ffmpeg libraries and the sample.mp4 file. I’m puzzled! Any guidance gratefully received. BTW do you accept contributions for a couple of coffees? 😊 From: John Stamatakis ***@***.***> Sent: Wednesday, January 24, 2024 8:06 PM To: SuRGeoNix/Flyleaf ***@***.***> Cc: davsun55 ***@***.***>; Mention ***@***.***> Subject: Re: [SuRGeoNix/Flyleaf] Brilliant library, but I'm struggling with limited doco... (Issue #419) Hi @davsun55<https://github.com/davsun55> and thanks! I know that the documentation requires more work that's why I tried to include more samples/tests and also check XML documentation/comments. 1. Not sure what you want to do here (you can SeekAccurate to 2sec and then use TakeSnapshotToFile/TakeSnapshotToBitmap) or use PropertyChanged for CurTime and check when the current time is 2sec? 2. Stop should work like that (closing the input and clears the frame). What you need is to Pause and Seek(0). 3. Seek will seek at a keyframe (this means that it will not be accurate, depends from the video's GOP size) but it will be faster while SeekAccurate will be accurate but slower (as it needs to decode all the GOP frames until the actual timestamp). SeekBackward(2/3) and SeekForward(2/3) will use Seek or SeekAccurate based on Config.Player.SeekAccurate and the time offsets based on Config.Player.SeekOffset(2/3) 4. Don't use this, always use the Player Set/Seek time and then use this without a frame (to get the current one) Feel free to ask for more details John — Reply to this email directly, view it on GitHub<#419 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMHB5F2HQ35EGN7LED27DZDYQDFJDAVCNFSM6AAAAABCGRAZEWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBXGY4DOOJZGE>. You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>

[SuRGeoNix]

@davsun55 You just found some issues here I guess. The problem is the Sync/Async combination. You can't use OpenAsync and then Seek directly as it will not be opened yet. You can either use OpenCompleted event or synced Open. The problem after that is that you Seek is not synced and I don't provide Synched version of it or an event. It will work if you for example put a Thread.Sleep in between just to prove it works. However, I will need to provide a better way for that (it can be done with ShowFrame but just found an issue with it when used directly after open).

Buy me a beer when you come in Greece/Crete :)

[SuRGeoNix]

@davsun55 With this commit now you can use this:-

Player.OpenAsync(@"c:\sample.avi");
Player.OpenCompleted += (o, e) =>
{
    if (!e.Success)
        return;
    
    Player.ShowFrame(Player.VideoDecoder.GetFrameNumber(TimeSpan.FromSeconds(2).Ticks));
    Player.TakeSnapshotToFile(@"c:\sample.jpg");
};

I will review also Seek/SeekAccurate if can use a synced version or an event

[SuRGeoNix]

@davsun55 I've added SeekCompleted so now you can better use the following:-

Player.Config.Player.AutoPlay = false;

Player.OpenCompleted += (o, e) =>
{
    if (!e.Success)
        return;
    
    Player.Seek(20_000);
};

Player.SeekCompleted += (o, e) =>
{
    if (e == -1)
        return;

    Player.TakeSnapshotToFile(@"c:\sample.jpg");
};

Player.OpenAsync(@"c:\sample.avi");

[davsun55]

Since I'm taking the snapshot to immediately show a thumbnail of the video before they press play, the .OpenCompleted doesn't work quickly enough. However this works:
flPlayer.Open(SampleVideo);
Thread.Sleep(500);
pbSnapshot.Image = flVideo.Player.TakeSnapshotToBitmap();
flPlayer.Stop();
But it would be good to have a solution that doesn't require the somewhat arbitrary thread.sleep.
We were in Greece in 2014 and loved it - especially the Moussaka on Rhodes! And we decided that Greeks make the best Turkish Delight.
:)

[SuRGeoNix]

@davsun55 This should work if you set the Player.Config.Player.AutoPlay = false;

[davsun55]

I can wait till your next NuGet release so you don't need to answer this, but how do I incorporate your Player.SeekCompleted changes right now? I've downloaded the current package with your changes, rebuilt it as 'release' and copied the resultant FlyleafLib.dll and FlyleafLib.xml over the top of the v3.7.42 package files. But Player.SeekCompleted is not present...

[SuRGeoNix]

The easiest way would be just adding the FlyleafLib project to your solution and reference it instead of using the NuGet package. Alternative you can release (pack) a new version custom and add a local repository folder in your VS. I would have a version for your but I want to review it before release it (I think i will do few changes).

[davsun55]

Thanks - I've got it working. Almost. I trust this is my last question: What I'm trying to do is to grab a frame from say 2 seconds in, as a thumbnail for the video, and of course the video repositions to the frame that gets snapped. However I'm having trouble resetting the video to the first frame after the snap: flPlayer.Config.Player.AutoPlay = false; flPlayer.OpenCompleted += (o, e) => { if (!e.Success) return; flPlayer.SeekAccurate(2000); }; flPlayer.SeekCompleted += (o, e) => { if (e == -1) return; pbSnapshot.Image = flVideo.Player.TakeSnapshotToBitmap(); }; flPlayer.OpenAsync(SampleVideo); Whenever I stop the video or seek(0) the frame that's snapped is the first one. Presumably because the event handler is still attached. Can I remove it, or is there a better way to do this? I obviously don't want to capture a snapshot after every seek. Thanks again, David From: John Stamatakis ***@***.***> Sent: Thursday, January 25, 2024 9:49 AM To: SuRGeoNix/Flyleaf ***@***.***> Cc: davsun55 ***@***.***>; Mention ***@***.***> Subject: Re: [SuRGeoNix/Flyleaf] Brilliant library, but I'm struggling with limited doco... (Issue #419) The easiest way would be just adding the FlyleafLib project to your solution and reference it instead of using the NuGet package. Alternative you can release (pack) a new version custom and add a local repository folder in your VS. I would have a version for your but I want to review it before release it (I think i will do few changes). - Reply to this email directly, view it on GitHub<#419 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMHB5FZ46HAIMUC2OMNC26DYQGFVZAVCNFSM6AAAAABCGRAZEWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBZGA2DQMBTGE>. You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>

[SuRGeoNix]

If understood correctly:-

flPlayer.Config.Player.AutoPlay = false;
flPlayer.OpenCompleted += (o, e) =>
{
    if (!e.Success) return;
    flPlayer.SeekCompleted -= FlPlayer_SeekCompleted;
    flPlayer.SeekCompleted += FlPlayer_SeekCompleted;
    flPlayer.SeekAccurate(2000);
};

flPlayer.OpenAsync(SampleVideo);
...
private void FlPlayer_SeekCompleted(object sender, int e)
{
   flPlayer.SeekCompleted -= FlPlayer_SeekCompleted;
   if (e == -1) return;
   pbSnapshot.Image = flVideo.Player.TakeSnapshotToBitmap();
}

You could also check the e (int e) which is the ms that is 2000 (and not 0)