Giter Site home page Giter Site logo

Comments (3)

fwsmaster avatar fwsmaster commented on May 24, 2024

Thank you for reporting and the suggested codefix.

Can you please help answer the following?

You mention the intended use of the FileType field in AnswerUploadItem.cs. If checking the code all the way to its use in the UI screens (e.g. voter report, file manager, or on the survey form) it does not seem to be an issue.

FileType field is never used, except in the filemanager where it shows up correctly (using a different Stored procedure). Adding the FileType field to the Stored procedure will therefore have no visible effects on screen or cause a malfunction of a particular feature.

Question: did you find any places where the FileType is actually missing on the UI i.e. should appear but doesnt or cause a malfunction?

Note: the suggested fix will be added for reasons of consistency.

from surveyproject.

jonpikum avatar jonpikum commented on May 24, 2024

Now that you mention it, no, I don't see anywhere in the UI that it is being used or displayed... Upon closer inspection, the only time it's referenced is on the download, upload, and delete buttons when setting the LinkButton's CommandArgument...

button.CommandArgument = string.Format("{0},{1},{2},{3}", new object[] { fileId.ToString(), groupGuid, fileName, fileType });

I only noticed because I was sifting through the code and debugging and noticed the property was null even though it was being referenced

On a side note, I noticed that vts_spFileGetDetails also does not return the FileType

from surveyproject.

w3devpro avatar w3devpro commented on May 24, 2024

Corrected in SP v. 2.4

from surveyproject.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.