Giter Site home page Giter Site logo

Comments (9)

commandlinegeek avatar commandlinegeek commented on June 17, 2024

I also tried to remove the class "nepalify" dynamically and it didn't help. But I guess you must have a toggle feature for it.

from nepalify.

suvash avatar suvash commented on June 17, 2024

hey hey ! glad to know that it's of use. Before I go ahead and fix the problem, just to be clear, what is it that you actually require ?

  • Is it the ability to toggle it on and off ? This should be simple enough for me to implement.
  • or handle DOM changes dynamically (add, remove "nepalify" class). There's already an issue #1 open for this, haven't had the time to work on it.

Do lemme know !

from nepalify.

suvash avatar suvash commented on June 17, 2024

Okay, added an issue #3 now ! Please weigh in your ideas, opinions there. Cheers.

from nepalify.

commandlinegeek avatar commandlinegeek commented on June 17, 2024
  1. Does DOM changes means, i can remove class for a single element? then yes.
  2. Toggle on/off means for a whole page then, it's needed too. (Maybe not for me if #1 is available)

Both are equally needed. But you can prioritize.

from nepalify.

suvash avatar suvash commented on June 17, 2024

well, DOM changes (with what I have in mind) would basically inspect the page during any DOM changes (not sure if this is possible in all browsers), and then add or remove the 'nepalify-cation' to any elements that has or does not have 'nepalify' (or a custom) class.
Quite useful, when for example changing/injecting/removing DOM elements using JS. But, will require more error handling and thinking to implement properly.

On the other hand, I can add the toggle feature, which would allow one to toggle it off.
This feature could also be abused to toggle it off and then on again, (after you add/remove 'nepalify' class), to make for a poor man's version of the above feature.

In short, I can add the toggle feature, which can be used to solve your problem for now, but will add the smartypants dynamic DOM inspection feature later, when I've some more time to think it through.

from nepalify.

commandlinegeek avatar commandlinegeek commented on June 17, 2024

sure and thanks.

from nepalify.

suvash avatar suvash commented on June 17, 2024

@tneupaney so, the toggling feature has landed. Also make sure you check the Readme. I've updated it. Cheers.

from nepalify.

commandlinegeek avatar commandlinegeek commented on June 17, 2024

thanks dude!

from nepalify.

suvash avatar suvash commented on June 17, 2024

🍻

from nepalify.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.