Comments (2)
Shouldn't this be generalized to all inheritable attributes, or is this a special case caused by it not being marked as inheritable or something?
from svgo.
Shouldn't this be generalized to all inheritable attributes
I haven't looked into it enough to say, but valid take.
It probably applies to all inheritable attributes, and probably should be handled in a utility that flattens the given node into its parent, which we can use everywhere we do this. We'd have to exclude children that set the same attribute as the removed parent did.
But then the annoying part, which is why I reported the issue instead. When testing xml:space
before, it looks to me that while xml:space="preserve"
applies to children, most browsers then ignore xml:space="default"
from children so it continues to preserve whitespace despite being overridden, and I wanted to investigate this further.
from svgo.
Related Issues (20)
- Problem with setup HOT 4
- removeUselessDefs removes <symbol> which contains children with IDs
- removeHiddenElems removes <symbol> which contains children with IDs
- v3.2.0 'Cannot read properties of undefined' error in reflectPoint HOT 1
- collapseGroups does not move attributes atomically HOT 2
- Fail to install with npm HOT 2
- Add an option to always keep/add `Z` in `convertPathData` HOT 4
- prefixIds fails to prefix when classes and comments are on the same line HOT 2
- Stringifies path data with extra 0s HOT 1
- Error: EMFILE: too many open files HOT 1
- Misoptimised svg: File becomes empty after applying svgo 3.2.0 with default settings HOT 1
- Remove trailing M
- Multiple plugins make unsafe transformations in the presence of a style element.
- some URL references not detected properly HOT 1
- Optimize SVG Sprites HOT 3
- cleanupAttrs in 'preset-default' overrides is not respected
- Improve node.children handling HOT 9
- `nxp svgo@latest a.svg -o b.svg` doesn't work HOT 3
- Option to change props to React Pattern HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from svgo.