Giter Site home page Giter Site logo

Comments (6)

Vampire avatar Vampire commented on May 19, 2024 1

PR #72 fixes the problem

from svn2git.

Vampire avatar Vampire commented on May 19, 2024

I'm no expert in c++ builds and makefiles, but this looks spurious: CommandLineParser.o -L -lsvn_fs-1
-L expects a directory as argument, as none is given, I guess -lsvn_fs-1 is used as argument and then is missing on its own which would add the svn_fs_file_contents to the linker context which it complains is missing.
So somehow where something should come after -L, comes nothing.
Do you have all pre-requisites on your box?

from svn2git.

k4rtik avatar k4rtik commented on May 19, 2024
diff --git a/src/src.pro b/src/src.pro
index 426d304..521b53c 100644
--- a/src/src.pro
+++ b/src/src.pro
@@ -28,7 +28,7 @@ DEPENDPATH += .
 QT = core
 
 INCLUDEPATH += . $$SVN_INCLUDE $$APR_INCLUDE
-!isEmpty($$SVN_LIBDIR): LIBS += -L$$SVN_LIBDIR
+#!isEmpty($$SVN_LIBDIR): LIBS += -L$$SVN_LIBDIR

After making the above change, the build works. Thanks for your help!

I do not understand why !isEmpty() is true above. I do not have SVN_LIBDIR in my environment AFAIK.

from svn2git.

Vampire avatar Vampire commented on May 19, 2024

This can easily be reproduced using

docker run -it --rm archlinux/base
pacman --noconfirm -Sy git gcc make qt5-base apr subversion
git clone https://github.com/svn-all-fast-export/svn2git
cd svn2git
qmake
make

from svn2git.

Vampire avatar Vampire commented on May 19, 2024

Actually the build also told you about the problem:

[root@170c996e434c svn2git]# make
cd src/ && ( test -e Makefile || /usr/sbin/qmake -o Makefile /svn2git/src/src.pro ) && make -f Makefile
/svn2git/src/src.pro:31: isEmpty(var) requires one argument.
make[1]: Entering directory '/svn2git/src'

At least on first execution (when there is no src/Makefile as it is during its generation where the error happens)

from svn2git.

Vampire avatar Vampire commented on May 19, 2024

Ok, the line should read
!isEmpty(SVN_LIBDIR): LIBS += -L$$SVN_LIBDIR
instead of
!isEmpty($$SVN_LIBDIR): LIBS += -L$$SVN_LIBDIR
On Linux and Windows I didn't have this problem before.
I don't know whether Archlinux is the culprit or maybe a different Qt version that behaves differently with the wrong syntax.

Even here, isEmpty($$SVN_LIBDIR) behaves wrongly, but the wrong behavior is, that it is always true, not always false like in arch linux.

from svn2git.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.