Comments (5)
In the meantime, you should be able to use negation in gulp.src
to exclude mori from minification.
from mori.
Yes, we could. Unfortunately our build process is having very long pipes, making it a bit too complicated.
All I am saying here is that npm packages should point to unminified code (from package.json, the main entry). And minified code can be either in a dist folder, a different name but ultimately it is up to the end user (developer) on how to minify, release and deploy it.
from mori.
from mori.
Hi, @binarykitchen !
Unfortunately, generating non-minifed source for Mori would either add a lot of dead code to the bundle, or require a new compilation mode in Google Closure Compiler.
Let me explain why:
Essentially, Mori is just a ClojureScript namespace, that imports some functions from ClojureScript core and export them under different names. The project is then compiled with Google Closure Compiler under Advanced compilation mode. This mode does several things:
- Performs full-program optimization and dead code elimination. (As a result, you don't get the entire ClojureScript source in the budnle, but only a fraction of it, that is required to support exported functions and data structures)
- Minifies the source.
Currently Google Closure Compiler doesn't have a mode that does dead code elimination but doesn't minify the source (for the list of available modes, see https://developers.google.com/closure/compiler/docs/compilation_levels)
So we could either accept the current situation, or bear with a lot of dead code in Mori unminified source.
I've tried to build Mori under WHITESPACE_ONLY compilation mode, and then uglify the result. The resulting bundle size was ~900k.
from mori.
@sesm thank you for your good response. Since I am unfamiliar with cljs compilers, I have no idea but what you say makes sense given the inherent nature of how ClojureScript compilation and optimisations work.
We will have to fix this ourselves within our own project.
from mori.
Related Issues (20)
- Calling m.toClj on an object with key "uc" breaks HOT 3
- How does Mori deal with functors, types, and interfaces in JS? HOT 9
- How do you get the index of a given string in a sequence of strings? HOT 3
- Documentation for transduce is missing
- Collections should implement toJSON
- React propTypes HOT 2
- doc typo: reduce
- doc typos: take
- doc typo: takeWhile
- doc typo: iterate
- doc typo: repeat
- doc typo: repeatedly
- set: what determines uniqueness?
- sortedSet: sort order
- A typo in documentation
- Essential vector methods missing? HOT 1
- Unix like Build Failing on fresh repository. HOT 1
- toClj throws exception for js object with property "j" having a numeric value HOT 1
- Is mori.js dead ? HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mori.