Lot of work in main thread

[swati4star]

Lot of work in main thread

[mihudevcom]

@khokharnikunj8 Let's wait for @Swati4star and see what she says.

[mihudevcom]

@Swati4star You need a loading dialog as well? Or just moving those to an AsyncTask will be enough? And why do you need an AsyncTask for this? I don't think it's loading that slow but maybe I'm missing something?

[Swati4star]

@mihudevcom Sure. Go ahead with this. If there is some issue, let me know. 👍

[Swati4star]

@khokharnikunj8 @mihudevcom Yes, I think I should close this issue.

[ShivamArora]

I see this might have been already handled as the pdf is being created within an AsyncTask called creatingPdf which is executed in the createPdf() method.

Is there anything else to be done?

[Swati4star]

You can move this tasks to Async Tasks.
View Files

[Swati4star]

Just adding the tasks to AsyncTasks would be enough. Also, adding a dialog would be an enhancement.

The addition of this is just for worst case scenarios. It might take a significant amount of time in slower phones or if there is some exception. This is just for those cases.

[mihudevcom]

@Swati4star Okay, sounds logical. Can I take care of this?

[mihudevcom]

@Swati4star Any other issues for this case?

[Kartikdot]

I am new to open source. Can i go ahead with the issue?

[khokharnikunj8]

I think its time for closing this issue . .. @Swati4star @mihudevcom