Giter Site home page Giter Site logo

Comments (8)

martin-lindstrom avatar martin-lindstrom commented on July 16, 2024

So, what does the error view say? Generally, we don't want to expose too detailed error messages for the user.

For some "unrecoverable" errors it is no point in having an "OK" button since the IdP don't know where to direct the user (since it is an invalid SP).

from bankid-saml-idp.

theseal avatar theseal commented on July 16, 2024

The same message as in the log might do it. Then the user get something in return which they can show the local helpdesk.
SAML SP 'https://release-check.qa.swamid.se/shibboleth' is not a registered BankID Relying Party

from bankid-saml-idp.

martin-lindstrom avatar martin-lindstrom commented on July 16, 2024

I am very reluctant to displaying that kind of messages for users. The problem you are referring to can only happen if an unregistered SP invokes the IdP. But, what does the error say today?

Our idea was to be able to configure errors with ID:s that can be used when communicating the customer support. @felix-hellman We have configuration settings for that. Right?

from bankid-saml-idp.

theseal avatar theseal commented on July 16, 2024

Configurable error messages sounds good to me! Like this one?

"unknown-peer": "The sender of the authentication request has not been registered at the Identity Provider",

Is it a bug that no text is displayed then?

Also the documentation points to messages.js but it have been renamed?

from bankid-saml-idp.

martin-lindstrom avatar martin-lindstrom commented on July 16, 2024

OK. I have been trying to ask you several time now. What is displayed? No text at all? That's clearly a bug.

from bankid-saml-idp.

theseal avatar theseal commented on July 16, 2024

Sorry. This is what it looks like:

Screenshot 2023-11-02 at 09 35 14

Notice: We are not running the latest code (and therefor the SC logo) since @mikaelfrykholm did some local patches in order to get the redis cluster to work while waiting for #205

from bankid-saml-idp.

martin-lindstrom avatar martin-lindstrom commented on July 16, 2024

OK. Thanks. Well, that's a bug!

from bankid-saml-idp.

martin-lindstrom avatar martin-lindstrom commented on July 16, 2024

Fixed in PR #212. Will be included in 1.1.1.

from bankid-saml-idp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.