Giter Site home page Giter Site logo

`autoSelect` option about sweetalert2 HOT 4 CLOSED

mifi avatar mifi commented on June 16, 2024
`autoSelect` option

from sweetalert2.

Comments (4)

limonte avatar limonte commented on June 16, 2024 1

Anyways I thought it might be a common use case to have the text auto selected, but whether it needs to be an option or not.. your call.

Nah, I don't think this small functionality deserves its own parameter 😄

Right.. maybe it's still better to explicitly list all those types that actually support the cursor though, in order to avoid possible bugs/errors from occurring (in certain browsers)?

Also nah, it has been like this several years already w/o any issue-reports. Listing all of them explicitly would create another place to keep in mind when adding new input types in future.

from sweetalert2.

limonte avatar limonte commented on June 16, 2024

Just to clarify, are you asking about making this:

Swal.fire({
  input: 'text',
  inputValue: 'test',
  didOpen: () => {
    Swal.getInput().select()
  },
})

a parameter?

from sweetalert2.

limonte avatar limonte commented on June 16, 2024

it places cursor in case of input.type !== 'file'. so for HTMLSelectElement it also places the cursor, however I'm not sure that HTMLSelectElement has a cursor? shouldn't it be changed to something like input.type === 'text' || input.type === 'textarea'?

You're right. For HTMLSelectElement it probably just silently does nothing w/o any errors or warnings.

input.type === 'text' || input.type === 'textarea' wouldn't be enough because there are 'email', 'phone', 'password', 'search' and many others

from sweetalert2.

mifi avatar mifi commented on June 16, 2024

a parameter?

Yes, although I didn't realise that it's actually that easy to do it 🙈 I can confirm that your code solves my problem too, thanks!

Anyways I thought it might be a common use case to have the text auto selected, but whether it needs to be an option or not.. your call.

input.type === 'text' || input.type === 'textarea' wouldn't be enough because there are 'email', 'phone', 'password', 'search' and many others

Right.. maybe it's still better to explicitly list all those types that actually support the cursor though, in order to avoid possible bugs/errors from occurring (in certain browsers)?

from sweetalert2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.