Comments (2)
Your assumption that this is intended is correct; we treat where
clauses as being on "equal footing" as the original declaration, because of situations like these:
class SomeClass<T, U, V>:
SomeSuperclass,
SomeProtocol,
SomeOtherProtocol
where
T.SomeAssociatedType == Foo,
U.SomeOtherThing == V
{
}
This indentation clearly delimits the section of inheritances/conformances from generic constraints, whereas indenting the where
keyword would blend them (which can be seen in the changes to the tests in your PRs), and also introduce an (IMO) unnecessary level of indentation in front of the entire section.
Since there's no "official/default/recommended" Swift style, if you'd like to continue pursuing your PRs then we're happy to explore alternative approaches, but since the current style applied by the formatter is being depended on by folks using it in production, any explicit style changes (rather than bug fixes) to that style will need to be placed behind a configuration option that is false
by default.
from swift-format.
Comment by Yusuke Kita (JIRA)
If that's the case, I'm totally okay with current format.
I think adding a new option in the configuration would be an alternative approach. However, I would like to hold until we get more demand from others to avoid adding unuseful option. I'll close this ticket
from swift-format.
Related Issues (20)
- Add a rule to disallow `public` extensions while allowing `private` and `fileprivate` ones HOT 3
- Missing option to allow trailing whitespaces on blank lines HOT 1
- Whitespace removed on Macro #Preview in SwiftUI HOT 1
- Split comments if they exceed the line limit HOT 2
- Split string literals into multiple lines HOT 2
- Wrapping of long function signatures HOT 4
- `Assertion failed: Too many unresolved delimiter token lengths` for enum cases with associated values when using `prioritizeKeepingFunctionOutputTogether: true` HOT 1
- Is `lineBreakBeforeEachArgument = true` broken? HOT 3
- Incorrect formatting for @_documentation HOT 2
- TrailingComma shows wrong line when AddLines present HOT 1
- `swift-format --recursive` recurses into `.build` HOT 2
- Adjust indentation when using multiple if-let expressions HOT 3
- Formatting results in duplicated top-level documentation HOT 2
- [Question] Can I strict the order of Closure annotation? HOT 1
- [Bugs?] `await` keyword mistake order when I use Swift-testing library. HOT 5
- Function to find and remove ASCII art from block comments is too finicky HOT 4
- Create a rule to add a specific format to file headers HOT 2
- Whitespace linting rules cannot be disabled HOT 1
- Error building swift-format in a Docker container HOT 5
- Typed throws in do blocks formatted incorrectly HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from swift-format.