[SR-11111] swift-format converts some classes to enums that are used as classes

[keith]

[SR-11111] swift-format converts some classes to enums that are used as classes

[allevato]

Yuck. The intent here was to fix unnecessary uses of class and struct as a namespace, but this is definitely a valid usage. Even if we did something like "look recursively for uses of self", that wouldn't catch a situation where there might be only-external references to the class.

I think struct -> enum should still be fine? But then I wonder if the rule continues to hold its weight. Maybe we should consider abandoning this one.

[keith]

I think maybe we should leave it the way it is and just expect users to opt out if they have a breakage like this? We have other cases in our codebase where we're doing this from other files so no matter what we wouldn't detect those

[allevato]

I believe pretty strongly that the formatter should not break any code under any circumstances. If a user is opting out of a rule, it should be for syntactic reasons, not to work around a transform that's so aggressive that it can't detect valid use cases.

[keith]

Sounds good, I think your suggestion will work then

[allevato]

This was fixed by #18.