Giter Site home page Giter Site logo

Comments (2)

jonah-williams avatar jonah-williams commented on June 14, 2024

I was just looking at this. I suspect the existing phone number rule has been excluded because it is too simplistic (it looks for a 10 digit string). As a result it only works in some countries, for non-international numbers, and requires preprocessing to strip dashes, parens, spaces, and any other characters users might reasonably enter into a phone number input.

A more complete rule might leverage https://github.com/iziz/libPhoneNumber-iOS but I don't know if it's worthwhile to add a dependency to SwiftValidator. Maybe phone number validation should be a subspec to make including it optional?

What do you think @jpotts18?

from swiftvalidator.

jpotts18 avatar jpotts18 commented on June 14, 2024

I would recommend extending the RegexRule and creating whatever phone number validation you need. I don't really want to bloat this library by adding all potential cases found in the libPhoneNumber-iOS library.

from swiftvalidator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.