Giter Site home page Giter Site logo

Comments (13)

luca-s avatar luca-s commented on June 20, 2024

Hi @kpapaza . I don't mind make the parameter configurable, but I need to double check with my colleagues, the experts of MLh, to verify if it makes sense at all to compute MLh at those depths. MLh was designed for Switzerland and so I would like to make sure it is scientifically sensible to allow such additional configuration.

from sed-seiscomp-contributions.

kpapaza avatar kpapaza commented on June 20, 2024

from sed-seiscomp-contributions.

luca-s avatar luca-s commented on June 20, 2024

Thank you for the detailed explanation @kpapaza . Knowing that you have a good understanding of the implications makes me more comfortable in allowing the configuration of this parameter. It would probably makes just sense to add a warning in the new parameter description stating something on the line "Change the default value of 80km only if you know what you are doing" ;)

Since you have already applied the changes on the code, would you like to provide a pull request? Or did you simply modified the hardcoded values?

from sed-seiscomp-contributions.

kpapaza avatar kpapaza commented on June 20, 2024

from sed-seiscomp-contributions.

luca-s avatar luca-s commented on June 20, 2024

Dear @kpapaza ,

to avoid that the next seiscomp release ships without this feature I moved on and implemented it myself. I thought it was easier for me to implement it since I always work on Seiscomp code.

I would like to ask you to double check that my changes work fine in your system and that you are getting the same MLh values as you currently do. You can find my change is in MLhmaxDepth branch. if you confirm it works fine I will merge it to master and it will be come available in the next SeisComP release.

The MLh magnitude bindings have now a maxDepth parameter.

Screenshot from 2023-04-13 13-17-33

However that is not enough, also the amplitude MLh bindings have to be configured with the desired maxDepth. This can be achieved by adding an "Amplitude type profile" with the name MLh (the name must be the same as the amplitude type). In there you'll find the maxDepth parameter for the amplitude.

Screenshot from 2023-04-13 13-17-55

Please let me know if everything works as expected .

Best
Luca

from sed-seiscomp-contributions.

gempa-jabe avatar gempa-jabe commented on June 20, 2024

Generally you could also easily implement that in a locale (localization of magnitudes). Each locale receives a minimum depth and maximum depth and a region (and some more). If a locale is set, then use its values to compute the magnitude. Your changes will also work, no problem, locales might be a more elegant solution although pretty new to SeisComP and not widely known yet.

from sed-seiscomp-contributions.

luca-s avatar luca-s commented on June 20, 2024

@gempa-jabe your proposal seems much more elegant. As you said, "It is not widely known yet", and indeed I was not aware of it :)

from sed-seiscomp-contributions.

gempa-jabe avatar gempa-jabe commented on June 20, 2024

The cool thing about locales is that you can also bind additional parameters for your particular magnitude and then customize the attenuation table as well. More fancy stuff with magnitudes to come ...

from sed-seiscomp-contributions.

kpapaza avatar kpapaza commented on June 20, 2024

Dear @luca-s,
thank you for the code modification and the introduction of this new feature. We will test it and let you know if we face any issues or changes, in comparison to the previous version and its calculations.

Dear @gempa-jabe,
thank you for your input. I was really not aware that it is possible to use such a feature (locale) to introduce a custom magnitude with its own attenuation table. This is not only elegant but also extremely useful, if e.g. localized attenuation tables have been proposed fot an area, country, region, etc.

Costas

from sed-seiscomp-contributions.

luca-s avatar luca-s commented on June 20, 2024

@kpapaza just to be clear, the changes are on a separate branch and until I merge them on the master branch of this code repository they will not appear in the next release. For this reason I would like to ask you to confirm that the changes in that branch work as expected for you. If you verify that I would then merge them to master to make them available in the next SeisComP release. Would you be able to do this test?

from sed-seiscomp-contributions.

kpapaza avatar kpapaza commented on June 20, 2024

@luca-s Thank you for the clarification, we will test this at our test Seiscomp installation, check how it performs using historical data (older deep events, with h > 80km) and get back to you when we have something solid...

from sed-seiscomp-contributions.

ogalanis avatar ogalanis commented on June 20, 2024

@luca-s I installed your branch and calculated some magnitudes, preserving the same configuration for everything else. The results are, as far as I can tell, and as expected, identical to our modified installation. I would recommend you merge it to the master branch.
Thanks again, on behalf of our network and other users with the same issue.

cc: @kpapaza

from sed-seiscomp-contributions.

luca-s avatar luca-s commented on June 20, 2024

Thank you for reporting back @ogalanis . I'll move on and merge this feature then. Unfortunately I see that SeicComP 5.4.0 has been already tagged so you'll see this feature on the next release.

from sed-seiscomp-contributions.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.