Fatal error: You must give a php image var to initialize a layer.

[sybio]

Fatal error: You must give a php image var to initialize a layer.

[aportela]

I can confirm that cloning master branch fix the problem, but when using the lib as composer dependency (dev-master branch) it still throws the exception (maybe the changes are not refreshed yet)

I set in composer.json the master branch

"sybio/image-workshop": "dev-master"

https://packagist.org/packages/sybio/image-workshop#dev-master

In any case, as I said before seems to be a composer refresh problem because downloading the main branch by hand works correctly

[Sybio]

Hi @corsachriz, are you sure to initialize with an image var ?

Can you add this line 140 in ImageWorkshopLayer.php and tell me what you get ?

echo gettype($image);

[aportela]

Hi,

Same error here

gettype($image) on __construct (ImageWorkshopLayer class) returns "object"

NOTE: I am using php (v8 x64) cli web server under Windows 10 Professional

php -v PHP 8.0.0 (cli) (built: Nov 24 2020 22:02:57) ( ZTS Visual C++ 2019 x64 ) Copyright (c) The PHP Group Zend Engine v4.0.0-dev, Copyright (c) Zend Technologies

Patching __construct method condition (adding "object" type) fixes the problem

if (gettype($image) != 'resource' && gettype($image) != '\resource' && gettype($image) != 'object') { throw new ImageWorkshopLayerException('You must give a php image var to initialize a layer.', static::ERROR_PHP_IMAGE_VAR_NOT_USED); }
I created a pull request

[jdecool]

Hi @aportela ,

Our library is not compatible yet with PHP 8.0.

There is a PR #132 to fix that.

[jdecool]

This issue should be fixed now on master branch.

Could you test it ?

I will tag a new version next week.

[jdecool]

Thanks for your feedback @aportela, it's really appreciated !

Github has changed the way to use webhook notification and it affects Packagist notification.

We don't updated the repository configuration yet.

I don't have the rights to do it.
@Sybio If you read us, could you update Packagist webhook 🙏 ?

[jdecool]

@aportela Version 2.2.0 with PHP 8 support just released