Comments (7)
I can confirm that cloning master branch fix the problem, but when using the lib as composer dependency (dev-master branch) it still throws the exception (maybe the changes are not refreshed yet)
I set in composer.json the master branch
"sybio/image-workshop": "dev-master"
https://packagist.org/packages/sybio/image-workshop#dev-master
In any case, as I said before seems to be a composer refresh problem because downloading the main branch by hand works correctly
from imageworkshop.
Hi @corsachriz, are you sure to initialize with an image var ?
Can you add this line 140 in ImageWorkshopLayer.php and tell me what you get ?
echo gettype($image);
from imageworkshop.
Hi,
Same error here
gettype($image) on __construct (ImageWorkshopLayer class) returns "object"
NOTE: I am using php (v8 x64) cli web server under Windows 10 Professional
php -v PHP 8.0.0 (cli) (built: Nov 24 2020 22:02:57) ( ZTS Visual C++ 2019 x64 ) Copyright (c) The PHP Group Zend Engine v4.0.0-dev, Copyright (c) Zend Technologies
Patching __construct method condition (adding "object" type) fixes the problem
if (gettype($image) != 'resource' && gettype($image) != '\resource' && gettype($image) != 'object') { throw new ImageWorkshopLayerException('You must give a php image var to initialize a layer.', static::ERROR_PHP_IMAGE_VAR_NOT_USED); }
I created a pull request
from imageworkshop.
Hi @aportela ,
Our library is not compatible yet with PHP 8.0.
There is a PR #132 to fix that.
from imageworkshop.
This issue should be fixed now on master
branch.
Could you test it ?
I will tag a new version next week.
from imageworkshop.
Thanks for your feedback @aportela, it's really appreciated !
Github has changed the way to use webhook notification and it affects Packagist notification.
We don't updated the repository configuration yet.
I don't have the rights to do it.
@Sybio If you read us, could you update Packagist webhook 🙏 ?
from imageworkshop.
@aportela Version 2.2.0 with PHP 8 support just released
from imageworkshop.
Related Issues (20)
- Move documentation to github repo HOT 4
- Fatal error: Uncaught Error: Class 'PHPImageWorkshop\Core\ImageWorkshopLayer' HOT 11
- Issue release in packageist HOT 1
- Right align text HOT 1
- Documentation Issues
- How to write Multi Line text
- GifCreator doesn't work
- White or Black bars with PNG and transparent background
- Webp support HOT 4
- Opening an optimized PNG (256 colors) result a grey block HOT 1
- Is it possible to wrap text to certain width ??
- GifCreator and global color palette?
- resizeToCover, like in css?
- PHP8 uses GDImage object instead resource HOT 4
- PHP Fatal error: Uncaught Error: Class "packages\PHPImageWorkshop\ImageWorkshop" not found HOT 1
- Problems with php 8.1 HOT 3
- Fix in convertHexToRGB method HOT 2
- Php Image Workshop supporting 8.1.13 or not HOT 1
- PHP deprecated function convertHexToRGB at php 8.1 HOT 7
- Working with grayscale png images
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from imageworkshop.