Giter Site home page Giter Site logo

Comments (10)

winzou avatar winzou commented on May 10, 2024

👎 prefixes keep sylius logic separated from the main app logic (in the db I mean).

from sylius.

marcospassos avatar marcospassos commented on May 10, 2024

I think it should be an option, not a requirement. As I said, it's can be done through Doctrine's events, giving us both options. In the current way you have just one option.

from sylius.

winzou avatar winzou commented on May 10, 2024

Do you think about http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/cookbook/sql-table-prefixes.html ?
If so, is there a mean to prefix only a bunch of tables (I think of only the sylius ones)? It would be a good solution.

from sylius.

marcospassos avatar marcospassos commented on May 10, 2024

Exactly. We can restrict the prefix only to Sylius tables, through namespace. So we can add a config option to allow prefix customization. It's a flexible and customizable solution, that allows enable/disable when desirable.

sylius:
    table_prefix: sylius_

from sylius.

winzou avatar winzou commented on May 10, 2024

👍 :)

from sylius.

pjedrzejewski avatar pjedrzejewski commented on May 10, 2024

I do not see big harm in prefixes, but if we can make them optional - +1, if we make them configurable - +2!

from sylius.

pjedrzejewski avatar pjedrzejewski commented on May 10, 2024

But I don't think we should remove them by default, I find it good practice, I clearly see what is part of custom app, and what is coming from Sylius, just like @winzou said!

from sylius.

marcospassos avatar marcospassos commented on May 10, 2024

Yes, this is my intention.

from sylius.

smalot avatar smalot commented on May 10, 2024

👍

from sylius.

elliot avatar elliot commented on May 10, 2024

Closable by #447 ?

from sylius.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.