Comments (10)
👎 prefixes keep sylius logic separated from the main app logic (in the db I mean).
from sylius.
I think it should be an option, not a requirement. As I said, it's can be done through Doctrine's events, giving us both options. In the current way you have just one option.
from sylius.
Do you think about http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/cookbook/sql-table-prefixes.html ?
If so, is there a mean to prefix only a bunch of tables (I think of only the sylius ones)? It would be a good solution.
from sylius.
Exactly. We can restrict the prefix only to Sylius tables, through namespace. So we can add a config option to allow prefix customization. It's a flexible and customizable solution, that allows enable/disable when desirable.
sylius:
table_prefix: sylius_
from sylius.
👍 :)
from sylius.
I do not see big harm in prefixes, but if we can make them optional - +1, if we make them configurable - +2!
from sylius.
But I don't think we should remove them by default, I find it good practice, I clearly see what is part of custom app, and what is coming from Sylius, just like @winzou said!
from sylius.
Yes, this is my intention.
from sylius.
👍
from sylius.
Closable by #447 ?
from sylius.
Related Issues (20)
- Cart summary should (not) include tax in estimated shipping costs HOT 2
- Invalid coupon code make the cart summary look weird HOT 2
- Allow the enabled property of a sylius_ui template to be defined using the ExpressionLanguage Component
- [ProductAttribute] "Apply To all" for select use the order position, not the value HOT 1
- Installation tutorial fails HOT 7
- Cart update success message displayed for empty discount code input
- Toast message does not close after multiple clicks on the close "X" icon HOT 1
- [CLI FEATURE] Command for deleting an admin user by the given username HOT 1
- [CLI FEATURE] Command for list available admin users
- BUG: [AdminBundle] missing <br> Tag in Product media tab twig template HOT 4
- Disabled products do not disappear from a cart HOT 1
- BUG: Missing spacing between upload image upload button in image_widget HOT 1
- How can I return back to the previous form page from the PRE_SUBMIT event with form values?
- [DOCS] Document available CLI commands for Sylius HOT 2
- Performance issue on admin dashboard HOT 5
- Wrong sorting of products in taxon after saving HOT 2
- Error When try to remove the last OrderItem of cart by Api HOT 1
- Issue with API Platform core v2.7.17 HOT 2
- [Order] Text going out of the frame in the Notes section HOT 2
- [UI] Different product box sizes on the product listing HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sylius.