ignored valid route names

[symfony-cmf]

ignored valid route names

[dbu]

ups, that was not the idea. but that means that this pattern is incorrect. the goal was to only try the default router if the route name is something that could actually work, to avoid breaking with exceptions, or ignoring exceptions that should not be ignored.

however, i don't see why your route name does not match the pattern we have, it looks like it should be fine.

while trying to link to where the expression came from i realized that the restriction on valid names was only active in 2.1 but got dropped in 2.2 aparently. so in the longer run we will just have to check for string, once we limit us to 2.2
https://github.com/symfony/symfony/blob/2.1/src/Symfony/Component/Routing/RouteCollection.php#L116 versus https://github.com/symfony/symfony/blob/2.2/src/Symfony/Component/Routing/RouteCollection.php#L120

[smatyas]

In my example, the route name contains '-' (hyphen) characters. That pattern does not match them.
I also tried to find the expression source, but I skipped the 2.1, only searched for it in 2.0 and 2.2 with no luck, now I understand why :)
I agree that checking for string will be enough.

[dbu]

ah right, the hyphens in the expression are just to express a range, not to allow hyphens.

for 2.1 we still need the expression. i wonder if there is a clean way to know the installed version of the symfony routing component - if not we could look out for a class that only exists in 2.2 to determine if we need the regexp. ugh.

[dbu]

so finally i merged that, its now in master.

[smatyas]

Thank you, David! 👍