Giter Site home page Giter Site logo

Comments (15)

martinqt avatar martinqt commented on July 1, 2024

Indeed there's not since maintaining a 2.0 branch (knowing that 2.1 is more advised) would create a huge amount of work. However, i think that if you want to handle a 2.0 branch, you are welcome. Also, i think you're right: the 2.0 mention in the readme should be deleted.

Wait and see what the admin are gona say.

from symfony-docs-fr.

greg0ire avatar greg0ire commented on July 1, 2024

Oh I'm not saying there should be maintenance for this 2.0 branch, I'm saying the README.md should be updated to reflect the contribution policies for this particular repository instead of those of symfony/symfony

from symfony-docs-fr.

martinqt avatar martinqt commented on July 1, 2024

Sorry for the misunderstanding.

from symfony-docs-fr.

greg0ire avatar greg0ire commented on July 1, 2024

No problem, I realize didn't make it very clear.

from symfony-docs-fr.

martinqt avatar martinqt commented on July 1, 2024

If you want, i think you can submit a PR or i can do it if your running out of time.

from symfony-docs-fr.

greg0ire avatar greg0ire commented on July 1, 2024

I'm not, but I have no idea what the contributing guidelines should be for this repo.

from symfony-docs-fr.

martinqt avatar martinqt commented on July 1, 2024

I think that something like

sur la branche 2.1, et non pas sur la branche master.

should do. For now we (almost?) follow the english repo workflow. So if i'm not getting it wrong, should be a PR against 2.1.

It will maybe change (#171)

from symfony-docs-fr.

greg0ire avatar greg0ire commented on July 1, 2024

Made a pull request : #184

from symfony-docs-fr.

greg0ire avatar greg0ire commented on July 1, 2024

I made a PR here : #185 , but it got closed because I didn't get it correctly. The problem still remains: how are we supposed to do our PRs to symfony-docs-fr ?

from symfony-docs-fr.

martinqt avatar martinqt commented on July 1, 2024

As you did except we don't get ahead of the English one. We just translate. If there is a mistake, we have to leave it until it got fix into the English one.
Hope it helps you understand how it works.

from symfony-docs-fr.

greg0ire avatar greg0ire commented on July 1, 2024

I understand how it works, and I think the README.md (or at least the contribution-related part of the README.md) should be an exception to the "just translate" rule. The README.md file is used by github to present a small summary about symfony-docs-fr, and people willing to contribute to this precise repository read it : that's what I did. If you still don't wish to change this, that's ok though: let's juste hope contributors will find this issue.

BTW, why is the "comment" button disabled, I did not really wish to close this issue.

from symfony-docs-fr.

martinqt avatar martinqt commented on July 1, 2024

I agree, but since the admins have this guidline...

@gregquat I know it's a load of work but we should try to do something for the workflow.
@greg0ire take a look at #171. Your point of view would be useful.

The comment button might be a small interruption in your connection (it works with ajax).

from symfony-docs-fr.

gregquat avatar gregquat commented on July 1, 2024

As I told in PR #185, you can edit or add a sentence to explain that it talks about adding something in the Symfony documentation and that this repo is only the translation.
And maybe you can add a sentence like "if you find a typo in the translation, make a PR in the 2.1 branch"

from symfony-docs-fr.

greg0ire avatar greg0ire commented on July 1, 2024

I think I eventually got it : #192

from symfony-docs-fr.

gregquat avatar gregquat commented on July 1, 2024

Thank you

from symfony-docs-fr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.