MercureBundle crashes when the request takes to long / to high load?

[symfony]

MercureBundle crashes when the request takes to long / to high load?

[dunglas]

Marking final classes in public libraries makes the maintenance way easier for us (and limits the number of potential BC breaks when you upgrade). Also, using composition instead of inheritance is considered a best practice these days.

[dunglas]

It looks like your hub isn't responding. Then it's "intended" that the bundle throws.

[Richard87]

I know, but I can't have it like that... So how can I "hack" it so it doesnt throw?

I'm trying to override it, but the "final" tag is complicating things...

[dunglas]

I would suggest to use the messenger integration (in async mode), then it will crash "silently", and the worker will retry later.

Another solution is just to use try/catch where you call the publisher (you can tweak the timeout etc by passing options to the Symfony HttpClient).

[Richard87]

Okay, thanks to my previous hack I managed to "silence" the error to just log a warning instead... for the next user, I'm hooking into API-Platforms Mercure publish logic:

But I don't really understand why "everything" have to be final these days, it makes it much harder to tweak things, like the Publisher that just have a single __invoke function... why final?

    App\Service\Doctrine\PublishMercureCollectionUpdatesListener:
        tags: [{name: doctrine.event_subscriber, connection: default, priority: 150}]
        decorates: 'api_platform.doctrine.listener.mercure.publish'
        arguments:
            $formats: "%api_platform.formats%"
            $messageBus: null
            $publisher: "@mercure.hub.default.publisher"
            $logger: "@logger"

[Richard87]

Yup, I understand that as a guideline,

And I agree about composition over inheritance, and API-surface etc.

But If I need to change the way Publisher pushes messages, adding information or similar, I need a place to hook in.

And overriding 'api_platform.doctrine.listener.mercure.publish' just because it's not final is not ideal. Ofcourse, that means I can publish my own Mercure-Bundle to handle the integrations, and it depends on how flexible you want this library to be. I would love to contribute to MercureBundle instead of competing (I'm still working on how to publish updates to collection in a good way my current way is failing with a timeout because of way to much unnecessary traffic!).

I just don't understand why a simple class like Publisher needs to be final, especially since it just need a invoke method that takes a Update object...

anyway, thanks for helping out so fast, I really appreciate it :)