[HttpFoundation] Flash messages showing up twice

[symfony]

[HttpFoundation] Flash messages showing up twice

[choffmeister]

I guess this happens, if u add a flash message and do not redirect. The general scenario is

• post a form
• progress the form, add a flash, redirect to another page
• show the page redirected to

To make the flashmessage visible it lifes exactly two page calls (the redirecting page and the page after).

[Burgov]

Strange... What happens if the request is redirected twice? Will the Flash message disappear?

[choffmeister]

Haven't tested it but I guess yes.

[choffmeister]

In symfony 1 there was an Boolean parameter at the setFlash method named persist. If it was false, then the flash message only lifed one call (for non redirected pages) and if it was true, then it lifed two calls (for redirected pages).

[michelsalib]

You are right. But I keep asking myself why flash should persist until one first call and then be flush. So that we never have to care about if the page is redirected or not.

[vlechemin]

On Tue, May 3, 2011 at 9:09 PM, choffmeister
[email protected]
wrote:

I guess this happens, if u add a flash message and do not redirect. The general scenario is

• post a form
• progress the form, add a flash, redirect to another page
• show the page redirected to

To make the flashmessage visible it lifes exactly two page calls (the redirecting page and the page after).

You are right, it's indeed what happens. Thanks,

Vincent

[vlechemin]

I'm not sure it would work, but isn't it better to flag the flash
messages as old when we are in the render view event instead of when
the session starts?

Vincent

[Seldaek]

The thing is that flash messages are only useful when you redirect. If you don't redirect, then you can just pass the message to your template straight away, no need to go through the session store for that.

If you do redirect, then the system works well, unless you redirect twice in a row, but I really don't see why you would do that. This is bad practice for performance reasons, especially on mobile connections; and the valid use cases for doing this are extremely rare.

[fabpot]

@Seldaek gave a good explanation here. I'm closing this ticket.

[Glideh]

Wouldn't it be simpler to pop each fetched message ?
That is the behavior in Django. So the question is not asked.
And yes we can directly pass flashes to templates, we can also set our own session variables... :)

[fabpot]

@Glideh That's the behavior as of Symfony 2.1.

[Glideh]

Ho sorry I was using 2.0 :) thanks for the notice