New stable release sometime soon?

[syncthing]

New stable release sometime soon?

[virusman]

Yup. Will do over the weekend.

[xor-gate]

Ooh no, missed this one. Thanks for reporting 👍

[xor-gate]

Hi @vincentardern thanks for your question. Indeed after #71 is approved I would like to create a new release. Maybe in a week or so.

[xor-gate]

Hi @virusman could you smash together a signed v0.14.49-1 release and put the signed DMG in github releases? When all is fine I will update the appcast.xml.

[xor-gate]

Great, thanks!

[vincentardern]

:D you're the best

[virusman]

@xor-gate looks like release/0.14.49-1 is ahead of develop, and master is way behind develop. Since develop is now the main branch, what should master point to?

[xor-gate]

For branching I would like to use semi-gitflow. So develop is .. development. And master points always to a tag. I have merged release/0.14.49-1 which just updates the Info.plist. Still a tag must be created. So we should merge develop into master (release branch) and then tag it using github releases with v0.14.49-1.

[virusman]

So master is the latest stable (points to the same commit as the latest release tag) and develop is WIP? Is it just one-way flow (develop -> master + tag)?

[xor-gate]

Exactly see https://datasift.github.io/gitflow/IntroducingGitFlow.html.

[virusman]

Oh, release branches, got it. Thanks.

[xor-gate]

You could use gitflow tooling which wraps git commands. But if we have the same branching model and master has always a tag and develop is WIP and feature have feature/issue- i'm happy. Still need to document it in a CONTRIBUTING.md file.

[virusman]

Yeah, the only unusual thing for me is that the release branch gets merged both into master and develop.

[xor-gate]

Thanks @virusman the release works fine. Still fighting the auto-updater xml. @vincentardern the release will be available soon with the auto-updater or just download it manually from the releases tab on github!

[xor-gate]

@virusman I have updated te appcast and it seems to be broken te updater:

cat ~/Library/Logs/SparkleUpdateLog.log:

2018-08-06 17:18:30 +0000: The update archive isn't signed with a DSA key, and the app is signed with a new Code Signing identity that doesn't match code signing of the original app: Error Domain=NSOSStatusErrorDomain Code=-67050 "(null)" UserInfo={SecCSArchitecture=x86_64}. At least one method of signature verification must be valid. The update will be rejected.
2018-08-06 17:18:47 +0000: Error: An error occurred while extracting the archive. Please try again later. The update is improperly signed. (URL (null))

Hosted here: http://xor-gate.github.io/syncthing-macosx/appcast.xml

[xor-gate]

To reproduce download https://github.com/syncthing/syncthing-macos/releases/download/v0.14.46-1/Syncthing-0.14.46-1.dmg. Go to about -> check for updates.

[xor-gate]

Not sure why it is complaining:

jerry@Jerrys-iMac:[~/Downloads]
 > codesign -dvv Syncthing-0.14.46-1.app/
Executable=/Users/jerry/Downloads/Syncthing-0.14.46-1.app/Contents/MacOS/Syncthing
Identifier=com.github.xor-gate.syncthing-macosx
Format=app bundle with Mach-O thin (x86_64)
CodeDirectory v=20200 size=1252 flags=0x0(none) hashes=33+3 location=embedded
Signature size=8917
Authority=Developer ID Application: Victor Babenko (JUW2CNK88G)
Authority=Developer ID Certification Authority
Authority=Apple Root CA
Timestamp=19 Apr 2018 at 06:17:29
Info.plist entries=31
TeamIdentifier=JUW2CNK88G
Sealed Resources version=2 rules=13 files=39
Internal requirements count=1 size=196

jerry@Jerrys-iMac:[~/Downloads]
 > codesign -dvv Syncthing-0.14.49-1.app
Executable=/Users/jerry/Downloads/Syncthing-0.14.49-1.app/Contents/MacOS/Syncthing
Identifier=com.github.syncthing.syncthing-macos
Format=app bundle with Mach-O thin (x86_64)
CodeDirectory v=20200 size=1732 flags=0x0(none) hashes=48+3 location=embedded
Signature size=9009
Authority=Developer ID Application: Victor Babenko (JUW2CNK88G)
Authority=Developer ID Certification Authority
Authority=Apple Root CA
Timestamp=4 Aug 2018 at 23:15:13
Info.plist entries=31
TeamIdentifier=JUW2CNK88G
Sealed Resources version=2 rules=13 files=47
Internal requirements count=1 size=196

Full log:

2018-08-06 17:27:31 +0000: Extracting /Users/jerry/Library/Caches/com.github.xor-gate.syncthing-macosx/Sparkle/Syncthing 144901/Syncthing-0.14.49-1.dmg as a DMG
2018-08-06 17:27:33 +0000: copyItemAtPath:/Volumes/A3357253-1974-4696-9AAC-0259623CAAA4/.background toPath:/Users/jerry/Library/Caches/com.github.xor-gate.syncthing-macosx/Sparkle/Syncthing 144901/.background
2018-08-06 17:27:33 +0000: copyItemAtPath:/Volumes/A3357253-1974-4696-9AAC-0259623CAAA4/.DS_Store toPath:/Users/jerry/Library/Caches/com.github.xor-gate.syncthing-macosx/Sparkle/Syncthing 144901/.DS_Store
2018-08-06 17:27:33 +0000: copyItemAtPath:/Volumes/A3357253-1974-4696-9AAC-0259623CAAA4/.fseventsd toPath:/Users/jerry/Library/Caches/com.github.xor-gate.syncthing-macosx/Sparkle/Syncthing 144901/.fseventsd
2018-08-06 17:27:33 +0000: copyItemAtPath:/Volumes/A3357253-1974-4696-9AAC-0259623CAAA4/Applications toPath:/Users/jerry/Library/Caches/com.github.xor-gate.syncthing-macosx/Sparkle/Syncthing 144901/Applications
2018-08-06 17:27:33 +0000: copyItemAtPath:/Volumes/A3357253-1974-4696-9AAC-0259623CAAA4/Syncthing.app toPath:/Users/jerry/Library/Caches/com.github.xor-gate.syncthing-macosx/Sparkle/Syncthing 144901/Syncthing.app
2018-08-06 17:27:34 +0000: Code signature of the new version doesn't match the old version: identifier "com.github.xor-gate.syncthing-macosx" and anchor apple generic and certificate 1[field.1.2.840.113635.100.6.2.6] /* exists */ and certificate leaf[field.1.2.840.113635.100.6.1.13] /* exists */ and certificate leaf[subject.OU] = JUW2CNK88G. Please ensure that old and new app is signed using exactly the same certificate.
2018-08-06 17:27:34 +0000: host info: {
    build = 144601;
    format = "app bundle with Mach-O thin (x86_64)";
    identifier = "com.github.xor-gate.syncthing-macosx";
    requirements = "designated => identifier \"com.github.xor-gate.syncthing-macosx\" and anchor apple generic and certificate 1[field.1.2.840.113635.100.6.2.6] /* exists */ and certificate leaf[field.1.2.840.113635.100.6.1.13] /* exists */ and certificate leaf[subject.OU] = JUW2CNK88G\n";
    "signing-time" = "2018-04-19 04:17:29 +0000";
    teamid = JUW2CNK88G;
    version = "0.14.46-1";
}
2018-08-06 17:27:34 +0000: new info: {
    build = 144901;
    format = "app bundle with Mach-O thin (x86_64)";
    identifier = "com.github.syncthing.syncthing-macos";
    requirements = "designated => identifier \"com.github.syncthing.syncthing-macos\" and anchor apple generic and certificate 1[field.1.2.840.113635.100.6.2.6] /* exists */ and certificate leaf[field.1.2.840.113635.100.6.1.13] /* exists */ and certificate leaf[subject.OU] = JUW2CNK88G\n";
    "signing-time" = "2018-08-04 21:15:14 +0000";
    teamid = JUW2CNK88G;
    version = "0.14.49-1";
}
2018-08-06 17:27:34 +0000: The update archive isn't signed with a DSA key, and the app is signed with a new Code Signing identity that doesn't match code signing of the original app: Error Domain=NSOSStatusErrorDomain Code=-67050 "(null)" UserInfo={SecCSArchitecture=x86_64}. At least one method of signature verification must be valid. The update will be rejected.
2018-08-06 17:27:35 +0000: Error: An error occurred while extracting the archive. Please try again later. The update is improperly signed. (URL (null))

[xor-gate]

Yes I fucked up:

"designated => identifier \"com.github.syncthing.syncthing-macos\"

which was

"designated => identifier \"com.github.xor-gate.syncthing-macosx\"

[xor-gate]

So I have fixed it so the updater is happy. I have nuked the v0.14.49-1 dmg and changed it to prerelease (so the appcast generator will skip it). We should create a new v0.14.49-2 release with the changelog from v0.14.49-1 and add an extra note about PR #79.

[calmh]

Is it possible to release a new version (with the old identifier) that then will allow updated with the new, or are we stuck forever with the existing identifier?

[xor-gate]

@calmh this question I have not answered myself because I didn't investigate yet. Probably we are stuck forever (until we break the updater or add a Sparkle flag manual upgrade is required). It will not add anything usefull for the end user but indeed its not a nice situation.

[calmh]

It's not a problem, just curious. :)

[calmh]

FWIW the release-dmg job on the build server correctly builds and signs the DMG using my identity (sane as the syncthing binary itself). This could be used together with Sparkle, potentially - maybe using Sparkle DSA signing to bridge the gap between signing identities, if it cares.

[virusman]

I've built another .dmg and uploaded to v0.14.49-1

[xor-gate]

@virusman thanks it works now like a charm again. The appcast.xml is updated so people should auto-update in the next 24h from now.

[vincentardern]

The software update window for me still shows release notes that contain a reference at the top to the issue found in the sparkle auto updater migration, and to see this thread. I feel like this shouldn't be closed.

[xor-gate]

@vincentardern i'm not sure I understand you. An update has been released yesterday and you could manual force update from an installed application go to About -> Check for updates. The release can be manual downloaded here: https://github.com/syncthing/syncthing-macos/releases/tag/v0.14.49-1.

[vincentardern]

I get the result as seen in the attached screenshot when I try to update right now. I believe the "NOTE:" inside the white release notes section should not be there anymore, but it does show for me. Have I misunderstood a few posts above where the issue in the Sparkle updater was supposed to be resolved?

Thanks for your work on this btw