[🐛 Bug]: Sometimes calling metamask.confirmPermissionToApproveAll() method on Metamask approve window is failing using Playwright + Synpress as plugin

[DavitMkhitaryan]

[🐛 Bug]: Sometimes calling metamask.confirmPermissionToApproveAll() method on Metamask approve window is failing using Playwright + Synpress as plugin

[DavitMkhitaryan]

@duckception Please, take a look at this when you have time. This is currently blocking me and possibly other people using this method in Playwright + Synpress as a plugin setup. Thanks

[DavitMkhitaryan]

Here is the method which is failing:

async confirmPermissionToApproveAll() {
    const notificationPage = await playwright.switchToMetamaskNotification();
    await playwright.waitAndClick(
      notificationPageElements.allowToSpendButton,
      notificationPage,
    );
    await playwright.waitAndClick(
      notificationPageElements.approveWarningToSpendButton,
      notificationPage,
      { waitForEvent: 'close' },
    );
    return true;
  }

When commenting out the second part it started working successfully:

await playwright.waitAndClick(
      notificationPageElements.approveWarningToSpendButton,
      notificationPage,
      { waitForEvent: 'close' },
    );

Maybe this part of the code should be executed optionally based on some condition in Metamask, or it is extra at all. Please, take a look at this and update as it is a blocking issue. @duckception

[duckception]

Hey! You're using an incorrect function here 😅 For token approvals, you should be using confirmMetamaskPermissionToSpend. The confirmPermissionToApproveAll function is meant for NFT all approvals. Sorry for the confusion, I know this is a bit messy. The upcoming version of Synpress will have a simpler and more intuitive API 🫡

Please, let me know if it helps 🙏

[DavitMkhitaryan]

Thank you for a quick response @duckception ! But I cannot find a method called "confirmMetamaskPermissionToSpend" though, can you please suggest how to find it? I am using version ^3.7.2-beta.9

[DavitMkhitaryan]

Ok, found it, the name of the method now is "confirmPermissionToSpend" FYI @duckception. Thanks! Closing the issue

[DavitMkhitaryan]

Closing as not an issue. The correct method to use in this case is "confirmPermissionToSpend".

[duckception]

My bad, I've copied it over from our Cypress tests that have this additional Metamask word in it.