Giter Site home page Giter Site logo

Comments (4)

MWedl avatar MWedl commented on June 2, 2024

Hi,
renaming is currently only possible in the API. We have not yet built an UI for it. The API Endpoint to rename images is PATCH /api/v1/pentestprojects/<project-id>/images/<image-id>/.

A big challenge for renaming images in the UI is when images are referenced in multiple findings and notes. When renaming these references should also be updated to not break PDF rendering. However, findings might currently be locked and edited by other users.

In order to provide reliable renaming and updating of all references, we first need to get rid of locking and be able to support updating parts of the text while users are currently editing. Implementing concurrent editing via websockets (see #78 ) would solve these problems and be the requirement for this change to work reliably.

from sysreptor.

GrylledCheez avatar GrylledCheez commented on June 2, 2024

What if you stored the images as a sha-256 or similar hash be the key, then have the "name" be the visible link?

You could reference by the friendly name or the hash name like in a github comment.

from sysreptor.

MWedl avatar MWedl commented on June 2, 2024

There would be a discrepancy between the text in the markdown editor (reference by ID) and the preview (reference by name). Using ID references removes information from the link for named images (for pasted images with name "image-*" it stays the same).

from sysreptor.

aronmolnar avatar aronmolnar commented on June 2, 2024

You can name images as you want by copying and pasting an image file (instead of the image itself).

image

The filename is then used for storage.

from sysreptor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.