Comments (19)
We'll take a look.
from commit-message-lint.
🙏 Thank you!
from commit-message-lint.
@jamesobutler
We tried reproducing this but were not able to. One possible reason you saw the issue could be with another issue we were facing with our cloud provider sometime around August end. Can you check again?
from commit-message-lint.
Ok I tried some more testing again and here are my results:
Public repo, issue a PR from one branch to another within the repo, message lint: ✔️
^ then force push the branch, message lint: ✔️
Made repo Private, then force pushed the branch, message lint: ✔️
My specific case that I use:
Private repo (within organization), issue a PR from forked repo branch to main upstream branch, message lint: ✔️
^ then force push the forked repo's branch, message lint: ❌ (does not re-run)
When it doesn't re-run it doesn't show up in the PR checks area if message-lint is not a required check to pass before merging. The image I provided originally showed that it was not re-running with it as a required check for merging.
from commit-message-lint.
Hi @sumits-systango,
Were you able to reproduce based on the above notes?
from commit-message-lint.
@jamesobutler yes, we were able to reproduce and are working on a fix. It seems to be related to fork repositories. We'll let you know as soon as a fix is deployed.
from commit-message-lint.
Thanks so much! Very much appreciated.
from commit-message-lint.
Hi @sumits-systango! Any update on this work? Or will this be a wont-fix
for this project? Thanks!
from commit-message-lint.
@jamesobutler
We are currently loaded with several requests and some upgrades. And this change is taking longer than expected. But this is still in the list and will be rolled out soon.
from commit-message-lint.
any news on this?
from commit-message-lint.
Hi @renanfenrich @jamesobutler, We have deployed the change for the Issues you were having with the Forked Repositories.
Please check on your end and let us know if there are any issues.
from commit-message-lint.
@apresswala-systango I force pushed a branch tied to an already open PR from a private repo fork to the upstream private repo and the commit-message-lint check was not run. I then tried opening a new PR from a private repo fork to the upstream private repo and the commit-message-lint check also did not run.
from commit-message-lint.
Was this a server-side change? I see no recent pushed updates to this repo if it was for the app code. The last commit is from May 4th 2020.
from commit-message-lint.
Yes, this was a server side change @jamesobutler . We'll take a look and get back.
from commit-message-lint.
@sumits-systango Any update on this?
from commit-message-lint.
Hi @jamesobutler, We are debugging this at our end. We are trying to reproduce the issue you are facing with our repositories. It would take some more time for us to get back to you on this.
from commit-message-lint.
I have unfortunately uninstalled this GitHub app as it has continued to be broken.
from commit-message-lint.
Hi @jamesobutler
That's unfortunate for us. But this issue is not easily reproducible at our end, which is why it is taking so much time. I request you to try the app once again once this is fixed.
from commit-message-lint.
The problem I noticed is that commit message lint app
caches previous commit messages, never clear it, which leads to bugs.
Imagine I commit message wrongly first time and I then rename with using rebase
or amend
but app doesn't refresh previous commit messages list and answer with error - which is wrong.
from commit-message-lint.
Related Issues (20)
- Says it is not configured event I already setup it HOT 2
- Waiting for status to be reported HOT 9
- Read access to code permission HOT 2
- Wrong message being displayed HOT 2
- Check stucks on expected state HOT 7
- Lint is not working HOT 4
- Says failed but didnt HOT 3
- Can't enable the app, as its not showing up in status check section. HOT 14
- Check hangs and never reports HOT 8
- Checks not running HOT 1
- PR's with over 30 commits causes Commit Message Lint to hang in "expected" state. HOT 3
- Regex doesn't respect capitalized letters HOT 1
- App Commit Message Lint check doesn't run with PR, although integration is complete HOT 1
- Status not updated to success or failed it shows always "waiting for status to be reported" HOT 9
- Github Checks not running.
- Status not reported back: Get stuck with the status `Expected - Waiting for status to be reported`
- Message validation failed!!! HOT 2
- App not showing up in 'checks' section HOT 9
- It would be great to have a custom message on failure HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from commit-message-lint.