Giter Site home page Giter Site logo

Comments (7)

ajxn avatar ajxn commented on August 19, 2024 2

I would go for hook it on in prog-mode, as most programming additions should. Maybe control when it starts with a customizing variable using defcustom.

Alternatively, this can be turned on in example-config.el so they users can copy that file to config.el and make their own desitions. And that will be made easier if there are some lines of code there, possible comment out.

Have added an #52 how one could do this more structured in Rational Emacs.

from crafted-emacs.

japhir avatar japhir commented on August 19, 2024

Perhaps enable it only in certain modes? I pretty much always use it and only dislike it when typing smileys or frowneys. (Is this a call to include frowneys.el? 😜)

from crafted-emacs.

erikLundstedt avatar erikLundstedt commented on August 19, 2024

im basicly saying it shouldnt be on by default
only enabeling in some modes makes for an issue where there might be a mode no-one knows about that should have it

i felt it got in the way in fennel-mode(lisp dialect) and in elisp-mode which are places where you would think it would be the most usefull

from crafted-emacs.

japhir avatar japhir commented on August 19, 2024

You could do it for e.g. prog-mode, which then also works for all derived modes.

Interesting that particularly in a lisp it didn't work nicely. I have it on in org-mode, R, and email etc.. I never encountered any issues so I pulled it in.

Any other opinions on this?

from crafted-emacs.

erikLundstedt avatar erikLundstedt commented on August 19, 2024

i think it might be that i write the function-call and arguments first and add parens later sometimes
i guess i never got used to it

from crafted-emacs.

jeffbowman avatar jeffbowman commented on August 19, 2024

I have it on everywhere and find it useful. It works for me just fine in lisp modes. I prefer to have it turned on globally.

We might need to take a step back on things like this and evaluate how it fits with the principles of the project. Showing line numbers is another example where it should probably be left to the end user to configure it rather than provide one here.

Regardless, the user can always turn on/off things we decide here. Options for the user is to not use a module and only copy/paste the parts of the configuration they want into their own configuration, or use a module and then figure out how to turn off the bits they don't want. Sometimes that can be tricky to figure out. For example if they don't want doom-modeline, the user must figure out how to remove that from the after-init-hook, if they want a menu bar, they need to figure out how to update the default-frame-alist (or possibly just call menu-bar-mode), if they electric parens on (or off) they just need to figure out how to do that.

My suggestion is to see what people think, if there isn't a strong consensus (as there appears to not be here), then we use the Emacs defaults and don't provide anything further, in this case that means leaving electric-pair-mode off.

from crafted-emacs.

jeffbowman avatar jeffbowman commented on August 19, 2024

Closing in anticipation of Crafted Emacs V2.

from crafted-emacs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.