Should the msw implementation be created as an independent plugin?

[Scott-Fischer]

Should the msw implementation be created as an independent plugin?

[Scott-Fischer]

upgrading @ladle/react requires updating msw due to the peer dependency

msw is a direct dependency of Ladle and there are no other packages/peerDeps? I don't understand why you couldn't install msw@1 next to Ladle?

You're right, I was able to do this eventually, it just wasnt quite as intuitive as I thought. When first upgrading my version of ladle, it was automatically updating msw and generating a new mockServiceWorker.js file. If anyone else ends up in this situation, you can resolve it by uninstalling msw after upgrading ladle then reinstalling msw at the version of v1 that you want.

Btw, we are also using Jest + MSW2. It's not that difficult to setup, just need to make sure that you give back fetch and other native APIs that Jest is hiding.

I took some time and worked though this as well and was eventually able to restore functionality in jest with v2.

Thanks for the advice, I'll go ahead and close this issue.

[tajo]

upgrading @ladle/react requires updating msw due to the peer dependency

msw is a direct dependency of Ladle and there are no other packages/peerDeps? I don't understand why you couldn't install msw@1 next to Ladle?

Btw, we are also using Jest + MSW2. It's not that difficult to setup, just need to make sure that you give back fetch and other native APIs that Jest is hiding.

the msw implementation be created as an independent plugin

I am really trying to avoid that. The setup is not straightforward and supporting both MSW1+2 would add a lot of maintenance burden as well.