Comments (6)
Thanks for your feedback. Do you have any suggestion to fix it?
from tinykv.
use another dir to avoid tmpfs. for example current_dir/tmp
from tinykv.
I think this is a critical issue since most Linux distros mount /tmp
on tmpfs (systemd feature).
And it took me 2 hours to locate the problem which was in the test, not in my code. It was really an unpleasant experience. At least there should be a caveat in the doc.
from tinykv.
@rapiz1 Would you mind sending a fix, change the dir or add a caveat warning in the doc.
from tinykv.
func (c *Cluster) Start() {
......
+ _ = os.RemoveAll("./tmp")
+ _ = os.Mkdir("./tmp", 0755|os.ModeDir)
for storeID := uint64(1); storeID <= uint64(c.count); storeID++ {
- dbPath, err := ioutil.TempDir("", "test-raftstore")
+ dbPath, err := ioutil.TempDir("./tmp", "test-raftstore")
......
maybe somewhat like this? Or add mkdir&rm in Makefile.
RemoveAll
can be ignored. But when the test failed, the dir will be huge as clients do not call MustDelete
.
from tinykv.
What's the point of using directio here? I think performance and consistency across crash is not an issue since it's just a tutorial project. So we can just simply replace all directio.OpenFile
with os.OpenFile
and just drop directio out of badger. It works on Arch and it should work everywhere. @Connor1996
from tinykv.
Related Issues (20)
- What is the license for this project? HOT 3
- Clarification of the content in project3b HOT 1
- CallCommandOnLeader frequently received EpochNotMatch
- Clarification on the semantics of IterCF in project1 HOT 2
- The link for English-version raftstore is dead
- Error log output is not clear enough in TestRawNodeRestart2AC HOT 3
- Reading list url invalid
- Would transaction order conflict with apply order? HOT 1
- test-case疑问 HOT 3
- "'IOMasterPort' is deprecated" warning when making project1
- Results of GC are not processed HOT 2
- Help: make error HOT 2
- Autograding: Fail to Build & Test HOT 2
- Why the Autograding keeps waiting HOT 3
- Check region epoch before updating the region approximate size HOT 1
- Help clarify the usage of ApproximateSize
- Questions about the TestSplitVote2AA test HOT 2
- Some questions about the Peer.Destroy HOT 1
- Is there any typo? HOT 1
- Question on project2ab test case TestLeaderSyncFollowerLog2AB HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tinykv.