Giter Site home page Giter Site logo

Comments (8)

tompsota avatar tompsota commented on June 1, 2024 2

Hi,

we found a bug that kills the app when deviceID check is fired on iOS, instead of launching your reaction. Fix will be ready later today.

Thanks for bringing this up.

from free-rasp-reactnative.

msikyna avatar msikyna commented on June 1, 2024 1

Hello @nikhilborana ,
thank you for reporting this! We will look at it soon.

Kind regards,
Talsec team

from free-rasp-reactnative.

LydGol90 avatar LydGol90 commented on June 1, 2024 1

Hi, yes seeing a few of these crashes on our production app on iOS only (so far).

"react-native": "0.72.6",
"freerasp-react-native": "^3.6.0",

Using very simple implementation of useFreeRasp() as in docs

I wasn't sure if this was related to this code in FreeraspReactNative.swift, which deliberately kills the app

 /**
     * We never send an invalid callback over our channel.
     * Therefore, if this happens, we want to kill the app.
     */
    @objc(onInvalidCallback)
    private func onInvalidCallback() -> Void {
        abort()
    }

Many thanks

from free-rasp-reactnative.

nikhilborana avatar nikhilborana commented on June 1, 2024 1

You're welcome!!
Thanks for your swift action and dedication to improving the functionality of the library are truly commendable.

from free-rasp-reactnative.

nikhilborana avatar nikhilborana commented on June 1, 2024

it crashed on both debug and release schema. only for the first time.

"react-native": "0.73.4",
"freerasp-react-native": "^3.6.0",

from free-rasp-reactnative.

tompsota avatar tompsota commented on June 1, 2024

Just released v3.6.1 which should fix the problem.

from free-rasp-reactnative.

nikhilborana avatar nikhilborana commented on June 1, 2024

sorry to bother you guys, but now its giving Device Id not ok for the first time open and if I kill the app and reopen it is working fine.

from free-rasp-reactnative.

tompsota avatar tompsota commented on June 1, 2024

Hi @nikhilborana,

The deviceID can be triggered after app reinstallation if none other app from the same vendor is installed on the device.
First run compares the old DeviceID with current DeviceID and updates the DeviceID. When the app is opened for the second time, the current DeviceID is compared to the DeviceID from the first run, so callback is not triggered anymore. You can learn more in the wiki here.

So if you are reinstalling the only app installed from you, it is expected that deviceID is triggered.

If you don't mind whether app was reinstalled, then it is usually fine to ignore this callback.

from free-rasp-reactnative.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.