Enhancements

[tananaev]

Enhancements

[sampalmer]

While waiting for read() (here), if isClosed is set true (here), read() would throw Exception (here) even if readQueue is still receiving stdout/stderr data (here) and we have one or more messages to be read() and displayed yet.
I hope this makes sense 😄

Ah, yeah that makes sense thanks! I've been running into this bug as well, but I hadn't realised why it was happening until I saw your fix!

I've just raised #11 to get this fixed in com.tananaev.adblib as well. I implemented the fix without changing the API to keep things simple for existing apps that use code like this:

while (!stream.isClosed()) {
    stream.read();
    // etc
}

[tananaev]

Ideas sound good to me. Please make sure to make small PRs for each change, so it can be easily reviewed.

[mirfatif]

Sure!

Thanks.

Does that fix the issue where read() sometimes fails with an IOException instead of sending back the response text?

try (AdbStream stream = connection.open("shell:echo Hello world")) {
    byte[] response = stream.read();
    String responseText = new String(response, StandardCharsets.UTF_8);
    Assert.assertEquals("Hello world", responseText.trim());
}

While waiting for read() (here), if isClosed is set true (here), read() would throw Exception (here) even if readQueue is still receiving stdout/stderr data (here) and we have one or more messages to be read() and displayed yet.
I hope this makes sense 😄

So the following would definitely throw IOException on first read() without printing anything:

try (AdbStream stream = connection.open("shell:echo Hello world")) {
    SystemClock.sleep(1000);
    byte[] response = stream.read();
    System.out.println(new String(response, StandardCharsets.UTF_8).trim());
}

I've tried to fix this.

[sampalmer]

Will do!

Just regarding upgrading the protocol version, after further testing, it looks like the hanging connection issue wasn't related to protocol version after all, so I'll leave it at the original version.

[sampalmer]

Raised #7 for the thread safety issues

[sampalmer]

Raised #9 for timeout option

[sampalmer]

Raised #10 for auth exception

[sampalmer]

Closing this issue since it's been converted to pull requests

[mirfatif]

@tananaev @sampalmer may I merge recent PRs to com.cgutman.adblib (https://github.com/mirfatif/AdbLib)?

[sampalmer]

@tananaev @sampalmer may I merge recent PRs to com.cgutman.adblib (https://github.com/mirfatif/AdbLib)?

Sure!

I just looked at your fork and noticed you have a fix for AdbStream.read(): mirfatif/AdbLib@aaa08a4.

Does that fix the issue where read() sometimes fails with an IOException instead of sending back the response text?

try (AdbStream stream = connection.open("shell:echo Hello world")) {
    byte[] response = stream.read();
    String responseText = new String(response, StandardCharsets.UTF_8);
    Assert.assertEquals("Hello world", responseText.trim());
}