Giter Site home page Giter Site logo

Comments (12)

tanersener avatar tanersener commented on May 18, 2024

I guess picture-based subtitles were not tested. Can you provide a sample .srt file so I can test it?

from mobile-ffmpeg.

FengDeng avatar FengDeng commented on May 18, 2024

Hi, @tanersener
Here is demo,https://github.com/FengDeng/SOSubtitle/tree/master/SOSubtitle
Thanks for your help.

from mobile-ffmpeg.

tanersener avatar tanersener commented on May 18, 2024

Hi,
I made some tests with your project. Burning picture-based subtitles worked on IOS simulator but crashed on a real device with arm64 architecture. Is this the issue you encountered?

from mobile-ffmpeg.

FengDeng avatar FengDeng commented on May 18, 2024

Yes,It crashed on real devices.

from mobile-ffmpeg.

FengDeng avatar FengDeng commented on May 18, 2024

default

By the way,memory leaks...

from mobile-ffmpeg.

shoyu666 avatar shoyu666 commented on May 18, 2024

add subtitle by "-vf "
mp4 file size 22M
android memory Increased to 100M+

from mobile-ffmpeg.

tanersener avatar tanersener commented on May 18, 2024

By the way,memory leaks...

I see them too, unfortunately they come from ffmpeg libraries, no quick fix atm. Tried many things about them but modifying ffmpeg source is needed. Good thing is most of them are small in size, around a few KB. But some leaks in external libraries x265 and libvidstab are huge and wastes MBs. Will monitor them in new releases.

Your issue with subtitles is a bug. I'm working on it but can not give a time frame about the fix.

from mobile-ffmpeg.

tanersener avatar tanersener commented on May 18, 2024

Hi, a patch is released about this issue; v2.1.1 is published in cocoapods.

from mobile-ffmpeg.

FengDeng avatar FengDeng commented on May 18, 2024

Thanks your great project.I changed my way of implementation.Not use ffmpeg.
And I test 2.1.1 with my demo,picture-based subtitle is not work.

from mobile-ffmpeg.

tanersener avatar tanersener commented on May 18, 2024

OK mate; it's your decision to use FFmpeg or not. I just want to make sure everything is working properly.

There is an error on your project (https://github.com/FengDeng/SOSubtitle/tree/master/SOSubtitle). By applying the following two steps it is possible to successfully burn picture-based subtitles.

1. Add 方正大黑_GBK.ttf font to your project.

1

2. Update these two statements inside AppDelegate.swift

if let resourcePath = Bundle.main.resourcePath {
    MobileFFmpegConfig.setFontDirectory("\(resourcePath)", with: nil)
}

let r = MobileFFmpeg.execute("-i \(input) -vf subtitles=\(ass):force_style='FontName=方正大黑_GBK' \(output)")

Generated video will include subtitles.

2

from mobile-ffmpeg.

FengDeng avatar FengDeng commented on May 18, 2024

@tanersener
cool.Thanks very much.Sorry to trouble you.

from mobile-ffmpeg.

tanersener avatar tanersener commented on May 18, 2024

no trouble mate, anytime

from mobile-ffmpeg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.