Images for disabled menu items do not appear, except when hovering over them

[Kroc]

Images for disabled menu items do not appear, except when hovering over them

[tannerhelland]

This has been an absolutely hideous issue to debug, and after four hours of fighting it I'm simply implementing a cheap workaround.

The problem occurs because "Classic Theme" changes the behavior of a bunch of API calls related to menu icon placement, in essence "mimicking" an unthemed environment from the Win 2K era. PhotoDemon accounts for this and automatically falls back to a subclassing-based menu icon system, which is required on XP anyway, and which works quite well in an unthemed environment.

The subclassing system relies upon intercepting WM_DRAWITEM messages and responding accordingly. This works without incident on XP. Under the "Classic Theme" it also works fine, except in the case of disabled and non-hovered menus. For reasons I do not understand (and cannot find documentation on), the hDC included in the window message for disabled and non-hovered menus is completely invalid. Because it is invalid, any paint operations applied to it silently fail. If disabled AND hovered, the returned hDC is valid and drawing is fine - as you can see with the "ghosted upon hover" behavior.

Because I've already wasted half a day on this and can't find any rational explanation for the behavior, I'm just disabling drawing of disabled icons if the "classic" theme is in use.

[tannerhelland]

Well... there is another workaround, but I'm not sure I like it better. Instead of falling back to the subclassing method, we can still use the theming-based API calls to set menu icons. The spacing is very cramped, but upon further investigation, this appears to be the behavior that other applications adopt when run under the "Classic Theme."

Given the choice between a workaround that doesn't draw disabled icons at all, or one that draws all icons but with minimal margins BUT is the same behavior as other applications, I'm probably inclined to go with the second workaround.

Commit incoming.