Giter Site home page Giter Site logo

Comments (10)

schiller-manuel avatar schiller-manuel commented on June 18, 2024

so v1.18.3 does not have this error?
can you please fill your enviroment information, such as

  • operating system
  • node version
  • pnpm version

from router.

JoseBuendiaDigio avatar JoseBuendiaDigio commented on June 18, 2024

1.18.3 not have this error.

We tried in linux and windows, both recent versions.
node 20.11 and 20.10 and pnpm latest version (8.15)

from router.

schiller-manuel avatar schiller-manuel commented on June 18, 2024

can you please provide a minimal example repo?

from router.

JoseBuendiaDigio avatar JoseBuendiaDigio commented on June 18, 2024

I have attempt it but it's difficult due to dependencies.

I will try to explaint what we are doing.

We have a renderByComponent method,
image
That it's used to put a component inside the router context, when we want to render only a component. We have the memory leak in this method. But only in one test suite, all the others are running as usual.

We have another to render the routes but here we don't have the problem when navigating to the route that it is using this component.
image

And the component it's quite simple, have a useMatchRoute(), useTranslation(), useStyles() useQuery(), and a view that isn't to much complicated
This is the only component that it is using useMatchRoute() I have tried to remove it to see if the problem dissapears but no. Same with RQ, I tried to remove it but same problem.

from router.

JoseBuendiaDigio avatar JoseBuendiaDigio commented on June 18, 2024

Ok, I found something, when I comment the <Outlet /> that the component have it's working

from router.

schiller-manuel avatar schiller-manuel commented on June 18, 2024

can you put this into a small reproducer?

from router.

JoseBuendiaDigio avatar JoseBuendiaDigio commented on June 18, 2024

Should be something like the next one but I can't reproduce it by the moment
https://stackblitz.com/edit/github-t9bqm9?file=src%2Fmain.tsx

from router.

schiller-manuel avatar schiller-manuel commented on June 18, 2024

any luck with the reproducer?

from router.

JoseBuendiaDigio avatar JoseBuendiaDigio commented on June 18, 2024

Seems that yes, if you try with 1.18.4 isn't working but with 1.18.3 is working

from router.

JoseBuendiaDigio avatar JoseBuendiaDigio commented on June 18, 2024

Any news about this?

from router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.