Giter Site home page Giter Site logo

Failure to compile under clang 6.0 about json HOT 3 CLOSED

taocpp avatar taocpp commented on May 14, 2024
Failure to compile under clang 6.0

from json.

Comments (3)

nadiasvertex avatar nadiasvertex commented on May 14, 2024

After looking at the code, the check doesn't make much sense. width() is generally gonna return a signed size_t value. It will never be larger than uint64_t. You could check to see if it's less than 0, but otherwise I'm not really sure what you are checking here.

from json.

d-frey avatar d-frey commented on May 14, 2024

I was trying to shut up Visual Studio in 32 bit mode wherestd::size_t is 32 bits, but w could potentially be larger, although in practice that makes no sense. It's now the usual dance to keep three compilers in different versions and in both 32 and 64 bit mode happy, all using extremely high warning levels... 🤔

from json.

d-frey avatar d-frey commented on May 14, 2024

I guess limiting the indention to 256 should be enough for any reasonable real-world use-case and it might even catch errors if someone really messed up and sets the width to, say, a million spaces or something... plus the code will be much clearer...

from json.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.