Compile errors when cross-compiling for windows

[taocpp]

Compile errors when cross-compiling for windows

[robinchrist]

This is most probably related to 0411b42

We are using clang to crosscompile for windows - could it be that this breaks your assumption in that commit (include/tao/json/external/pegtl/internal/demangle.hpp)?

[d-frey]

Could you please change

return { begin + 2, sv.end() - begin - 3 };

to

return { begin + 2, sv.data() + sv.size() - begin - 3 };

and see if that works?

[robinchrist]

Sorry for the delay. I'm gonna try that later and get back to you asap!

[robinchrist]

The first bug I mentioned seems to be fixed.

However, there's a new one 😐

[16/144] Building CXX object CMakeFiles/addon.dir/src/SubwooferLibrary.cc.obj
FAILED: CMakeFiles/addon.dir/src/SubwooferLibrary.cc.obj 
/usr/bin/clang-cl-7  /nologo -TP -DNOMINMAX -DSPDLOG_ACTIVE_LEVEL=SPDLOG_LEVEL_WARN -D_USE_MATH_DEFINES -Daddon_EXPORTS -I/root/.cmake-ts/electron/win32/x64/v4.0.1/include/node -I../../../../../node_modules/nan -I../../../../../projectname/include -I../../../../../ff/src -I../../../../../projectname/include/taocpp/json/include -D_CRT_SECURE_NO_WARNINGS -EHsc -Xclang -std=gnu++17 --target=x86_64-windows-msvc -fms-compatibility-version=19.11 -Wno-unused-command-line-argument -imsvc /msvc/include -imsvc /winsdk/Include/10.0.17763.0/ucrt -imsvc /winsdk/Include/10.0.17763.0/shared -imsvc /winsdk/Include/10.0.17763.0/um -imsvc /winsdk/Include/10.0.17763.0/winrt -Xclang -ivfsoverlay -Xclang /builds/companyname/project-corelib/staging/win32/x64/electron/64/winsdk_vfs_overlay.yaml  -s /MP /arch:AVX2 /MD /O2 /Ob2 /DNDEBUG /O2 /fp:fast   -fcolor-diagnostics -std:c++17 /showIncludes /FoCMakeFiles/addon.dir/src/SubwooferLibrary.cc.obj /FdCMakeFiles/addon.dir/ -c ../../../../../src/SubwooferLibrary.cc
clang: warning: unknown argument ignored in clang-cl: '-s' [-Wunknown-argument]
In file included from ../../../../../src/SubwooferLibrary.cc:1:
In file included from ../../../../../src/SubwooferLibrary.h:5:
In file included from ../../../../../projectname/include/library/SubwooferLibrary.hpp:2:
In file included from ../../../../../projectname/include/library/SSOTLibraryBase.hpp:11:
In file included from ../../../../../projectname/include/library/ILibrary.hpp:9:
In file included from ../../../../../projectname/include/taocpp/json/include/tao/json.hpp:8:
In file included from ../../../../../projectname/include/taocpp/json/include/tao/json/events/../value.hpp:7:
../../../../../projectname/include/taocpp/json/include/tao/json/events/../basic_value.hpp(75,7):  error: exception specification of explicitly defaulted move constructor does not match the calculated one
      basic_value( basic_value&& r ) noexcept = default;
      ^
../../../../../projectname/include/taocpp/json/include/tao/json/from_string.hpp(32,34):  note: in instantiation of template class 'tao::json::basic_value<traits>' requested here
      [[nodiscard]] inline value operator"" _json( const char* data, const std::size_t size )
                                 ^
Note: including file:      ../../../../../projectname/include/taocpp/json/include/tao/json/parse_file.hpp
1 error generated.

As far as I remember, MSVC is a bit paranoid when it comes to noexcept constructors...

[d-frey]

I pushed another commit which removes the explicit noexcept specifier on defaulted SMFs as they should be implicitly noexcept anyways. In your case it means they are probably not anymore, but that is a bug in your cross-compiler toolchain. But I do hope this is an acceptable solution for you.

[robinchrist]

I suppose MSVC (or rather clang in compatibility mode) defaults back to having a non noexcept constructor of std::variant, because one of the classes has a non noexcept move constructor. I'll investigate that once I have some spare time.

Apart from that, removing the noexcept specifier is perfectly fine for me.

[robinchrist]

CI build works fine! Relevant commit is 5d18635