[FEAT] `--disable-coverage` should imply `--allow-empty-coverage`

[grahamb]

[FEAT] `--disable-coverage` should imply `--allow-empty-coverage`

[isaacs]

--allow-empty-coverage

Probably that should be implied if --disable-coverage is set, or maybe --disable-coverage could be renamed to --mysteriously-fail-and-post-a-github-issue-about-it 😅

[isaacs]

(You're not the first to fall for that trap, it's a terrible footgun, I'm sorry.)

[grahamb]

Thanks for the pointer, @isaacs; that solved the issue, just like the help docs says it would 🤦 . I should have read those more closely.

I can open a separate issue for this, but the reason I'm disabling coverage in my CI tests is that I'm using the JUnit reporter, and it seems to produce invalid XML. For example:

You can see that it starts the XML file, but then the coverage detail gets written to STDOUT, followed by the rest of the XML. I use a junit parser in my GitHub Actions workflow, and it barfs trying to parse this because it's invalid XML.

[isaacs]

The coverage details are being written to stderr, so you can split them out that way if you'd like. Or you can use --reporter-file=junit.xml and then use the file it creates, rather than trying to parse the combined stderr/stdout data.

[isaacs]

Aha, my mistake, the coverage report is indeed going to stdout.

You can also turn it off the report with --coverage-report=none, but it'll still fail if you don't generate full coverage, unless --allow-incomplete-coverage is set.