Giter Site home page Giter Site logo

DH_ARRAYSET implementation is wrong about botc HOT 8 CLOSED

 avatar commented on September 15, 2024
DH_ARRAYSET implementation is wrong

from botc.

Comments (8)

 avatar commented on September 15, 2024 1

Alright, I've written a smaller, more concise and fool proof answer in the tracker since someone wasn't able to spot the issue.

from botc.

TarCV avatar TarCV commented on September 15, 2024

Yes, result of the call memset(1, 1, 32768) in HUMANBOT would be globalArray1 elements all set to 0x01010101. And I'm not sure if memset command is actually useful for a modder.
But probably there is nothing to do to fix that on botc side. At least other than making the compiler stable enough to be used for building Zandronum wad, and thus allowing to use bot sources instead of compiled bytecode.

from botc.

 avatar commented on September 15, 2024

Is a simple for loop sufficient in the VM? The str type will have the same size as an int, right?

from botc.

TarCV avatar TarCV commented on September 15, 2024

I'm not sure it's possible to put a string value into a global array in bot scripts at all. I can't find any DH_ code that pops a string stack value and puts it into a variable or an array.

from botc.

 avatar commented on September 15, 2024

In any case, I have submitted a PR.
https://bitbucket.org/Torr_Samaho/zandronum-stable/pull-requests/89/bots-dh_arrayset-implementation-is-wrong/diff

from botc.

TarCV avatar TarCV commented on September 15, 2024

Thank you. May be it'll even fix some weird behavior of the bots.

from botc.

 avatar commented on September 15, 2024

Are you referring to this?
https://zandronum.com/tracker/view.php?id=3774

from botc.

 avatar commented on September 15, 2024

Commit corrected and accepted.
https://bitbucket.org/Torr_Samaho/zandronum-stable/commits/a04a4f94737e5ad3aad6573227e146b76f037d95

from botc.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.