Distribution and scanner unit testing

[target]

Distribution and scanner unit testing

[infosec-intern]

Is there a specific test module or format you want to use for this?

I added some version_info extraction to the scan_pe.py scanner and plan to add a test or two before I PR it. If not, I was just gonna use Python's built-in unittests module

[jshlbrd]

@infosec-intern if you're adding functionality to a scanner, then I wouldn't worry too much about a specific test case for the new code -- just document the tests you did do and describe them in the pull request. This issue is more about building a whole unit testing strategy -- this is something I don't have a ton of experience with, so if you're interested in building a proof of concept for how to run unit tests, then that would be great! Until we have unit testing figured out, I don't expect anyone to add them (though you're certainly welcome to).

[infosec-intern]

I'm working on the same for one of my own repositories. I can give building a full strategy a shot - I just wanted to make sure I wasn't reinventing the wheel here if you already had something in mind

I'll go ahead and add some tests for the rest of the ScanPe components too and figure out what works/doesn't work then.

[jshlbrd]

@infosec-intern that's a good idea--let's see how the tests for ScanPe work out and then we can make decisions starting from there.

[jshlbrd]

Based on the results of the ScanPe unit testing, I think the best way to move forward may be to start with unit tests for each scanner and the tasting functions. I'll close out this issue and create new ones for each scanner.