Giter Site home page Giter Site logo

Comments (11)

addyosmani avatar addyosmani commented on May 21, 2024 1

I'm assuming we'll have the lighthouse + interactive times as just separate points of the list as well?

Fore sure. I think highlighting the mobile performance of each implementation is particularly relevant for highlighting in the list.

As per Dan's feedback, we should probably remove the logo beside the name of the implementation. We can have it beside the mention of the framework/UI libraries used in the first point of the list (might help stress the fact that these tools aren't official library implementations).

This SGTM.

We should also probably have the author for each implementation as a separate point, should further help stress the fact that these examples aren't official

👍

This is what I'm envisioning in terms of how the design might change: http://hnpwa-updates.surge.sh/

This is a great start. How would you feel about us making better use of the horizontal space by having the summary next to the device? I was thinking:

  • device preview on the right (like current site)
  • the summary on the left. text in there is left aligned
  • summary includes the performance scores + lighthouse scores at the top

Very open to other ideas though!

from hacker-news-pwas.

kristoferbaxter avatar kristoferbaxter commented on May 21, 2024 1

Here are the details for Preact HN.

Framework/UI library
Preact, Preact Router

Module bundling
Webpack

Service Worker
Application Shell with OfflinePlugin

Performance patterns
HTTP/2 with Server Push, Brotli and Zopfli static assets

Server-side rendering
Yes

API
In-memory cached Hacker News Firebase API

Hosting
Webfaction + Cloudflare

from hacker-news-pwas.

housseindjirdeh avatar housseindjirdeh commented on May 21, 2024

I like the structured list as well. A couple of thoughts:

  • I'm assuming we'll have the lighthouse + interactive times as just separate points of the list as well?
  • As per Dan's feedback, we should probably remove the logo beside the name of the implementation. We can have it beside the mention of the framework/UI libraries used in the first point of the list (might help stress the fact that these tools aren't official library implementations).
  • We should also probably have the author for each implementation as a separate point, should further help stress the fact that these examples aren't official (as well as allow us to include multiple implementations for a single framework/library). We can just have their names here and still include their images at the footer.

Please let me know if you agree/disagree with some or all of this. Will hopefully get a PR for this by tomorrow!

from hacker-news-pwas.

housseindjirdeh avatar housseindjirdeh commented on May 21, 2024

This is what I'm envisioning in terms of how the design might change: http://hnpwa-updates.surge.sh/

from hacker-news-pwas.

housseindjirdeh avatar housseindjirdeh commented on May 21, 2024

Awesome thank you, yeah you're right not much use of space keeping vertically aligned. Always good to get a second pair of eyes on it. Appreciate the feedback!

from hacker-news-pwas.

housseindjirdeh avatar housseindjirdeh commented on May 21, 2024

http://hnpwa-details.surge.sh/

Suggestions welcome! If it looks decent enough, I'll submit the PR :)

Note: Once we finalize the design, would probably make sense to tag each author and ask them to include the details of their implementation themselves in the list. What do you think @addyosmani?

from hacker-news-pwas.

addyosmani avatar addyosmani commented on May 21, 2024

Thanks for hacking on this, @housseindjirdeh! Looking good so far.

Some drive-by feedback:

image

I like that we're playing around with iconography. I do wonder if it might be a little early to hope most developers landing on the site know what Lighthouse is or that the timings here are relation to 1) load and 2) interactivity.

One thing I love about the current design you put together (live) is that we spell these things out pretty clearly. Do you think it might be possible to play around with a text breakdown for the scores?

image

I'm a fan of each implementation's entry still being fully visible on an average sized monitor. Looking at the length of text for some of the fields, I wonder if we would save some of the vertical space by switching up from:

Module bundling
Webpack

to Module bundling: Webpack

and tried to do the same for any lines that are likely to have short answers.

The rest of this looks great to me however 👍

from hacker-news-pwas.

housseindjirdeh avatar housseindjirdeh commented on May 21, 2024

Cheers thank you @kristoferbaxter!

Updates: http://hnpwa-fresh.surge.sh

Awesome thanks again @addyosmani.

I like that we're playing around with iconography. I do wonder if it might be a little early to hope most developers landing on the site know what Lighthouse is or that the timings here are relation to 1) load and 2) interactivity.

I was thinking this, and you're most probably right. Definitely makes sense to keep the full texts there. Played around with a couple of different designs:

image

^ Didn't seem as nice on smaller screen sizes unfortunately.

image

^ Looked decent but still felt kinda off 🤔

Final design

image

Ended up removing the icons but please let me know if you would like me to incorporate them in some way.

I'm a fan of each implementation's entry still being fully visible on an average sized monitor. Looking at the length of text for some of the fields, I wonder if we would save some of the vertical space by switching up from:

Module bundling
Webpack

to Module bundling: Webpack

Good point, changed all of them to be inline texts (and if they happen to be long enough they'll show up as a separate line).


I also just allowed adding multiple items for the Frameworks/UI libraries section of the details list. Due to this, I removed the icon of the framework used (Angular logo, React logo, etc...). Let me know if you would have liked me to still include them however.

Let me know if there's anything else you can think I should change!

from hacker-news-pwas.

addyosmani avatar addyosmani commented on May 21, 2024

This looks really awesome, @housseindjirdeh. I think it ticks all the right boxes in my opinion 🎉

Due to this, I removed the icon of the framework used (Angular logo, React logo, etc...). Let me know if you would have liked me to still include them however.

To be honest, I think this was a good call. The header text makes it clear what framework we're talking about and we can highlight frameworks by linking them out to their respective sites.

Let me know if there's anything else you can think I should change!

Dan had one idea we could maybe incorporate. What if we had a link or button for submitting your own versions of HNPWA? Something that might make it clear these are community maintained examples. We could link to an issue template or just the 'spec'.

from hacker-news-pwas.

housseindjirdeh avatar housseindjirdeh commented on May 21, 2024

@addyosmani thank you, that's a great idea. PR opened for everything in #42 :)

from hacker-news-pwas.

addyosmani avatar addyosmani commented on May 21, 2024

Thanks once again for all of the great input folks. Closing as we have now landed this work and it should be live shortly.

from hacker-news-pwas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.