Comments (8)
@pieter-vanderwerff Do you mean this to be a pull request, or are you just making us aware that you are currently working on this? Do you plan to make the changes that you've listed or are you planning to hand this off and have us finish it?
from todomvc.
Im just making you aware of the state of this example. I will submit a pull request once the underscore AMD implementation issue has been resolved. Its a bit of a hard issue to solve, we may need to wait for version 0.6 of curl or since underscore has dropped AMD support we modify its source directly to wrap the define()
call around everything. Have you thought about what approach you will take for the backbone + require example when upgrading underscore? Modify the source or use a fork?
As for the other items, i assume they are not so urgent and shouldn't stop me from submitting a pull request. Also for consistency it would be better if you made the changes first to the backbone + require and i am happy to copy them over to this example when that is done.
from todomvc.
@pieter-vanderwerff Great work! I appreciate you getting this thing going so far. @addyosmani actually spoke up that he wanted to handle the upgrade of the backbone + require version, so he'll have to chime in on how he plans to handle that scenario, but it is an interesting point. It might make using backbone for our AMD implementation examples a bad idea. I agree that consistency is key, so hopefully Addy will be able to highlight what he plans to do.
Thanks again for the great work.
from todomvc.
@pieter-vanderwerff @boushley I think patching the source directly makes the most sense as we can then easily have a single copy of Underscore we can use for any examples requiring script loaders like curl or RequireJS. Happy for us to patch ourselves, but if we can locate a fork someone is maintaining that already has this that would be useful.
I would definitely say feel free to submit a PR which can then be later improved/fixed as needed. We probably won't be landing the curl example until after our next release, so that gives us plenty of time to work on it.
Thanks again, Pieter!
from todomvc.
Do you think its worth creating a README file in the libs directory which would list the repo/project/fork url, version number and any modifications for each library?
There has been some talk on the AMD implementation list of maintaining forks of all major libraries, hopefully something will come of this soon but in the mean time i will patch the source. https://groups.google.com/group/amd-implement/browse_thread/thread/78815161c34eeeac?pli=1
Ok great, thanks guys!
from todomvc.
@pieter-vanderwerff I was talking to James Burke earlier and he mentioned that a patched version is available via the amdjs group and pointed me at the readme in http://github.com/volojs/volo
from todomvc.
@pieter-vanderwerff
I didn't respond to your other question - I was initially going to suggest moving information about forks into the wiki, but a README in the lib directory will probably get read more. Would there be benefit in us making a preliminary list of patched libraries people creating todo apps can use?
from todomvc.
@addyosmani After having a play with volojs im not sure its worth making a list of patched libraries since volo makes it so easy to patch any library for use with AMD. But a section on AMD in the wiki would be useful with info about and links to both volojs and the amdjs forks (https://github.com/amdjs).
Yeah i agree with you about the README in the libs directory being more visible, seems like a simple but useful addition.
from todomvc.
Related Issues (20)
- Elm Visual Bug caused by "Active" filter.
- A new todo demo written in React 18 in here - https://k19wbt.csb.app/
- Update the broken link to Philiosophy behind react HOT 2
- Change footer's todo item filter anchor tag components to button tag
- [New App] Bonsai Framework
- Yew framework TODO request HOT 1
- Upstream Speedometer 3.0 TodoMVC apps
- More developer-friendly Ember builds HOT 3
- bug: Found this on https://todomvc.com/
- Azure cloud example for Todo
- Title HOT 1
- Thoughts on contributing an updated version of the React example
- Running tests with node 20.10 or 20.11 raises "ReferenceError: primordials is not defined" HOT 1
- Ember example link broken HOT 6
- Ember example link broken in index.html page
- Native app development
- Flutter
- React Native
- Astrojs SSR
- update Speedometer link
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from todomvc.