Giter Site home page Giter Site logo

Comments (10)

TatuLund avatar TatuLund commented on June 25, 2024 1

Thank you so much . is it version 3.0.1 or 3.1.0?

3.1.0

from twincolselect.

TatuLund avatar TatuLund commented on June 25, 2024

Yes, it is easy to replicate. I also tested Vaadin 14, which is much faster as well, probably no difference to Vaadin 23. So there is definitely something odd with Vaadin 24. The code between Vaadin 23 and 24 versions are 99% the same, so this makes it very odd. I did time benchmarking of the internal reset method, and that is not the bottleneck. I run also the Chrome dev tools profiler, and that reveals that time is burnt when items are rendered. Particularly there is one function in Flow client taking much time time, but the name is obfuscated, so I do not know what it is.

image

from twincolselect.

madhu1830 avatar madhu1830 commented on June 25, 2024

Agree , i had also seen the network calls where flow client function is running and it's taking too much time . But if we run the same functionality for 300 data items then it's working perfectly fine .
Also, is there any way to get all the Items from TwincolSelect so that we can append the items asynchronously in the Twincolselect because setItem overrides the Item (Not append them ) and there is not method named as getItems which is fetching the items from the TwincolSelect itself

from twincolselect.

TatuLund avatar TatuLund commented on June 25, 2024

and there is not method named as getItems which is fetching the items from the TwincolSelect itself

That method is in DataView.

        dataView = select.setItems(items);
        dataView.getItems();

Also, is there any way to get all the Items from TwincolSelect so that we can append the items asynchronously in the Twincolselect

Why? It will not help with the rendering issue ...

from twincolselect.

TatuLund avatar TatuLund commented on June 25, 2024

same functionality for 300 data items then it's working perfectly fine .

Yes, observed the same. There must be something quadratic complexity in rendering phase as with smaller counts the performance is tolerable.

When I added 1000 similar custom Checkboxes as I have in TwinColSelect to normal VerticalLayout it is not slow

image

In this profile I do not see insertBefore taking time. I am a bit puzzled, as what TwinColSelect does internally is the same.

from twincolselect.

TatuLund avatar TatuLund commented on June 25, 2024

I also noticed that this slowness happens with Chrome/Edge. With Firefox it is not slow.

from twincolselect.

madhu1830 avatar madhu1830 commented on June 25, 2024

I also noticed that this slowness happens with Chrome/Edge. With Firefox it is not slow.

yes it's faster in Firefox then Chrome/Edge but in vaadin 23 it's rendering even faster then Firefox(with vaadin 24 ).There is difference of 3-4 secs in rendering .

from twincolselect.

TatuLund avatar TatuLund commented on June 25, 2024

Fixed by version 3.1.0

from twincolselect.

TatuLund avatar TatuLund commented on June 25, 2024

image

from twincolselect.

madhu1830 avatar madhu1830 commented on June 25, 2024

Thank you so much . is it version 3.0.1 or 3.1.0?

from twincolselect.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.